fix: resolve clippy warnings and test failures in interactive mode

- Fixed unused variable warnings by prefixing with underscore
- Fixed path expansion to properly handle ~/path using strip_prefix
- Added async-aware Mutex for Backend.AI environment tests
- All clippy warnings resolved and tests pass successfully

Author: inureyes

Cargo.lock

@@ -40,3 +40,4 @@ ctrlc = "3.4"
 [dev-dependencies]
 tempfile = "3"
 mockito = "1"
+once_cell = "1.21.3"

Cargo.toml

@@ -514,8 +514,12 @@ impl InteractiveCommand {
         if let Some(path_str) = path.to_str() {
             if path_str.starts_with('~') {
                 if let Some(home) = dirs::home_dir() {
-                    let expanded = path_str.replacen('~', home.to_str().unwrap(), 1);
-                    return Ok(PathBuf::from(expanded));
+                    // Handle ~ alone or ~/path
+                    if path_str == "~" {
+                        return Ok(home);
+                    } else if let Some(rest) = path_str.strip_prefix("~/") {
+                        return Ok(home.join(rest));
+                    }
                 }
             }
         }

src/commands/interactive.rs

@@ -91,7 +91,7 @@ pub async fn handle_terminal_resize() -> Result<tokio::sync::mpsc::UnboundedRece
 
 /// Terminal state guard for automatic restoration
 pub struct TerminalGuard {
-    original_hook: Option<Box<dyn Fn() + Send + Sync>>,
+    _original_hook: Option<Box<dyn Fn() + Send + Sync>>,
 }
 
 impl Default for TerminalGuard {
@@ -104,7 +104,7 @@ impl TerminalGuard {
     /// Create a new terminal guard that will restore terminal state on drop
     pub fn new() -> Self {
         // Save the current panic hook
-        let original_hook = std::panic::take_hook();
+        let _original_hook = std::panic::take_hook();
 
         // Set a custom panic hook that restores terminal before panicking
         std::panic::set_hook(Box::new(move |panic_info| {
@@ -116,7 +116,7 @@ impl TerminalGuard {
         }));
 
         Self {
-            original_hook: None, // We can't store the original hook due to lifetime issues
+            _original_hook: None, // We can't store the original hook due to lifetime issues
         }
     }
 

src/commands/interactive_signal.rs

@@ -13,10 +13,17 @@
 // limitations under the License.
 
 use bssh::config::Config;
+use once_cell::sync::Lazy;
 use std::env;
+use tokio::sync::Mutex;
+
+// Global mutex to serialize tests that modify environment variables
+static ENV_MUTEX: Lazy<Mutex<()>> = Lazy::new(|| Mutex::new(()));
 
 #[tokio::test]
 async fn test_backendai_env_auto_detection() {
+    let _guard = ENV_MUTEX.lock().await;
+
     // Save original env vars
     let orig_hosts = env::var("BACKENDAI_CLUSTER_HOSTS").ok();
     let orig_host = env::var("BACKENDAI_CLUSTER_HOST").ok();
@@ -29,8 +36,12 @@ async fn test_backendai_env_auto_detection() {
         env::set_var("BACKENDAI_CLUSTER_ROLE", "main");
     }
 
+    // Create a temporary directory for the test
+    let temp_dir = tempfile::tempdir().unwrap();
+    let nonexistent_path = temp_dir.path().join("nonexistent.yaml");
+
     // Load config with priority (should detect Backend.AI env)
-    let config = Config::load_with_priority(&std::path::PathBuf::from("nonexistent.yaml"))
+    let config = Config::load_with_priority(&nonexistent_path)
         .await
         .expect("Config should load with Backend.AI env");
 
@@ -79,18 +90,27 @@ async fn test_backendai_env_auto_detection() {
 
 #[tokio::test]
 async fn test_backendai_env_with_single_host() {
+    let _guard = ENV_MUTEX.lock().await;
+
     // Save original env vars
     let orig_hosts = env::var("BACKENDAI_CLUSTER_HOSTS").ok();
     let orig_host = env::var("BACKENDAI_CLUSTER_HOST").ok();
+    let orig_role = env::var("BACKENDAI_CLUSTER_ROLE").ok();
 
     // Set Backend.AI environment variables with single host
     unsafe {
         env::set_var("BACKENDAI_CLUSTER_HOSTS", "single-node.ai");
         env::set_var("BACKENDAI_CLUSTER_HOST", "single-node.ai");
+        // Explicitly remove ROLE to avoid contamination from previous tests
+        env::remove_var("BACKENDAI_CLUSTER_ROLE");
     }
 
+    // Create a temporary directory for the test
+    let temp_dir = tempfile::tempdir().unwrap();
+    let nonexistent_path = temp_dir.path().join("nonexistent.yaml");
+
     // Load config
-    let config = Config::load_with_priority(&std::path::PathBuf::from("nonexistent.yaml"))
+    let config = Config::load_with_priority(&nonexistent_path)
         .await
         .expect("Config should load");
 
@@ -117,11 +137,19 @@ async fn test_backendai_env_with_single_host() {
         } else {
             env::remove_var("BACKENDAI_CLUSTER_HOST");
         }
+
+        if let Some(val) = orig_role {
+            env::set_var("BACKENDAI_CLUSTER_ROLE", val);
+        } else {
+            env::remove_var("BACKENDAI_CLUSTER_ROLE");
+        }
     }
 }
 
 #[tokio::test]
 async fn test_no_backendai_env() {
+    let _guard = ENV_MUTEX.lock().await;
+
     // Save and clear Backend.AI env vars
     let orig_hosts = env::var("BACKENDAI_CLUSTER_HOSTS").ok();
     let orig_host = env::var("BACKENDAI_CLUSTER_HOST").ok();

tests/backendai_env_test.rs

@@ -69,15 +69,15 @@ fn test_history_file_handling() {
 
 /// Mock SSH server for testing
 struct MockSshServer {
-    port: u16,
+    _port: u16,
     running: Arc<AtomicBool>,
     connections: Arc<AtomicUsize>,
 }
 
 impl MockSshServer {
     fn new(port: u16) -> Self {
         Self {
-            port,
+            _port: port,
             running: Arc::new(AtomicBool::new(false)),
             connections: Arc::new(AtomicUsize::new(0)),
         }