Skip to content

Commit a33363e

Browse files
committed
fix: Address issues in OpenTelemetry audit exporter
HIGH: - Fix test code compilation by using tuple indexing (.0, .1) for KeyValue attributes instead of struct field access - Add endpoint URL validation using url::Url::parse() with error context - Add HTTPS validation warning for insecure HTTP endpoints MEDIUM: - Replace Mutex with RwLock for logger_provider since emit() only requires read access, improving concurrent performance - Add TLS requirements documentation in endpoint parameter docs - Convert all synchronous tests to async with #[tokio::test] to satisfy gRPC client initialization requirements Dependencies: - Add url crate 2.5 for URL parsing and validation
1 parent 5f104ce commit a33363e

3 files changed

Lines changed: 329 additions & 34 deletions

File tree

Cargo.lock

Lines changed: 257 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ serde_json = "1.0"
7272
opentelemetry = "0.21"
7373
opentelemetry_sdk = { version = "0.21", features = ["rt-tokio", "logs"] }
7474
opentelemetry-otlp = { version = "0.14", features = ["grpc-tonic", "logs"] }
75+
url = "2.5"
7576

7677
[target.'cfg(target_os = "macos")'.dependencies]
7778
security-framework = "3.5.1"

0 commit comments

Comments
 (0)