Commit cce72c6
authored
feat: Implement public key authentication for server (#147)
* feat: Implement public key authentication for server
Add authentication provider infrastructure for bssh-server:
- Create AuthProvider trait for extensible auth backends
- Implement PublicKeyVerifier with OpenSSH authorized_keys parsing
- Support both directory and pattern-based authorized_keys locations
- Integrate auth provider with SSH handler for auth_publickey
- Add rate limiting for authentication attempts
- Include comprehensive security features:
- Username validation to prevent path traversal
- File permission checks on Unix systems
- Logging for auth attempts (success/failure)
Configuration supports two modes:
- Directory mode: {dir}/{username}/authorized_keys
- Pattern mode: /home/{user}/.ssh/authorized_keys
Closes #126
* fix: address critical and high severity security issues in public key authentication
CRITICAL Issue Fixed:
- Fix TOCTOU race condition in load_authorized_keys by removing path.exists()
check and handling NotFound from read operation. Use symlink_metadata to
detect symlinks before reading.
HIGH Severity Issues Fixed:
- Add group-writable permission check (0o020) in check_file_permissions
- Fix user enumeration timing attack in user_exists by using constant-time
behavior - always perform same operations regardless of username validity
- Add directory ownership and permission validation in load_authorized_keys
- Fix symlink check in get_user_info to use symlink_metadata
MEDIUM Issue Fixed:
- Share rate limiter across handlers via Arc to provide server-wide rate
limiting instead of per-instance limiting
Security Improvements:
- Use symlink_metadata consistently to avoid following symlinks
- Validate parent directory permissions (not world-writable, warn on group-writable)
- Check ownership consistency between file and parent directory
- Reject both world-writable and group-writable authorized_keys files
- Prevent user enumeration through timing attacks
All tests pass with cargo test and cargo clippy.
* chore: finalize PR with documentation and formatting
- Update ARCHITECTURE.md with comprehensive auth module documentation
- Add authentication module reference to docs/architecture/README.md
- Apply cargo fmt formatting to publickey.rs1 parent 1f2ac4f commit cce72c6
8 files changed
Lines changed: 1466 additions & 16 deletions
File tree
- docs/architecture
- src/server
- auth
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
198 | 198 | | |
199 | 199 | | |
200 | 200 | | |
| 201 | + | |
201 | 202 | | |
202 | 203 | | |
203 | 204 | | |
204 | 205 | | |
205 | 206 | | |
206 | 207 | | |
207 | 208 | | |
| 209 | + | |
208 | 210 | | |
209 | 211 | | |
210 | 212 | | |
211 | 213 | | |
212 | 214 | | |
| 215 | + | |
213 | 216 | | |
214 | 217 | | |
215 | | - | |
| 218 | + | |
| 219 | + | |
216 | 220 | | |
217 | 221 | | |
218 | 222 | | |
| |||
221 | 225 | | |
222 | 226 | | |
223 | 227 | | |
224 | | - | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
225 | 280 | | |
226 | 281 | | |
227 | 282 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
36 | 37 | | |
37 | 38 | | |
38 | 39 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
0 commit comments