Commit 4497104
authored
update: bump MLX upstream pin to 84961223 (PRs )
Picks up upstream (CUDA qmm_naive / qmm_sm80 kernel bodies extracted into new qmm_naive.cuh / qmm_sm80.cuh headers — public ABI of the symbols declared in mlxcel's patches/.../qmm.h is unchanged),
(CPU JIT preamble routed through JitCompiler::get_preamble
and the prebuilt symbol renamed from get_kernel_preamble to get_prebuilt_preamble — mlxcel does not call either directly), and
(AsStrided contiguity-flag accuracy fix in mlx/backend/common,
computing data_size from the actually-occupied stride range).
Three-location pin update applied per CLAUDE.md:
- src/lib/mlx-cpp/CMakeLists.txt (GIT_TAG)
- src/lib/mlxcel-core/build.rs (MLX_EXPECTED_COMMIT) -.github/workflows/release.yml (MLX_EXPECTED_COMMIT env)
Patch headers retargeted to the new commit:
- patches/mlx/backend/cuda/quantized/qmm/qmm.h
- patches/mlx/backend/cuda/quantized/quantized.cpp
Fused Metal kernel launchers in src/lib/mlx-cpp/turbo/ revalidated on Apple Silicon. The relevant symbols (mlx::core::fast::metal_kernel, mlx::core::full, mlx::core::Shape, mlx::core::float32, mlx::core::int32, metal::fast::exp) are unchanged across the bump; the three required correctness tests pass with significant headroom on the RMS<5e-3 gate:
sparse_v_kernel_threshold_zero_matches_graph OK delegated_fused_kernel_matches_reference_over_200_steps RMS = 1.7263e-4 delegated_steel_envelope_matches_cold_only_fused_over_200_steps RMS = 1.5259e-41 parent d97593a commit 4497104
6 files changed
Lines changed: 16 additions & 9 deletions
File tree
- .github/workflows
- src/lib
- mlx-cpp
- patches/mlx/backend/cuda/quantized
- qmm
- mlxcel-core
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
236 | 236 | | |
237 | 237 | | |
238 | 238 | | |
239 | | - | |
| 239 | + | |
240 | 240 | | |
241 | 241 | | |
242 | 242 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
17 | 20 | | |
18 | 21 | | |
19 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
92 | | - | |
| 92 | + | |
93 | 93 | | |
94 | 94 | | |
95 | 95 | | |
| |||
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
5 | 7 | | |
6 | 8 | | |
7 | 9 | | |
| |||
Lines changed: 6 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
8 | 10 | | |
9 | 11 | | |
10 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
137 | | - | |
| 137 | + | |
138 | 138 | | |
139 | 139 | | |
140 | 140 | | |
| |||
0 commit comments