Commit 6e10f48
authored
chore(ci): move clippy + test from PR-time CI to release pipeline (#21)
The `clippy + test (macOS ARM64)` job in ci.yml was burning ~15 minutes
of the single shared self-hosted Apple Silicon runner on every PR push.
That cost was hard to justify given that:
- Local developers now have `make verify` / `make verify-clean` which
reproduce the exact same `cargo clippy --features metal,accelerate
-- -D warnings` + `cargo test --release --features metal,accelerate`
invocation, so the runner round-trip wasn't adding signal that wasn't
reachable locally.
- The self-hosted runner is shared with the release pipeline, and PRs
routinely starved release builds for runner time.
This commit:
1. Removes the `clippy-and-test` job (and the now-obsolete header
comment block) from `.github/workflows/ci.yml`. PR-time CI now runs
only the lightweight cargo-deny + cargo-fmt gates on ubuntu.
2. Adds the same fmt / clippy / test steps to `release.yml`'s
`build-macos` job, in front of the signed-build step. A clippy or
test regression in release builds will now fail the release before
any signing or packaging work happens.
`release.yml::build-macos` already uses the same self-hosted runner with
a persistent cargo target cache, so the lint/test steps benefit from
incremental compilation and don't redo the full build for the artifact
step that follows.1 parent 8dcc84c commit 6e10f48
2 files changed
Lines changed: 26 additions & 31 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
6 | 12 | | |
7 | 13 | | |
8 | 14 | | |
| |||
76 | 82 | | |
77 | 83 | | |
78 | 84 | | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
96 | 96 | | |
97 | 97 | | |
98 | 98 | | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
99 | 114 | | |
100 | 115 | | |
101 | 116 | | |
| |||
0 commit comments