Follow-up to #1 A-section.
The packaging GitHub deployment environment currently has:
required_reviewers: inureyes (1 user)
prevent_self_review: false
can_admins_bypass: true
This means the person who triggers a signing or homebrew-bump deployment can also self-approve it — which provides an "abort window" before the deployment proceeds, but is not a true 4-eyes gate. This was an intentional choice while release tooling was still being automated (see the follow-up note in #1 A-section).
Once the release pipeline is fully automated (manual signing/notarization no longer required, manual homebrew bump no longer required), this configuration should be hardened:
Tasks
Triggering conditions
Open this issue for action when all of the following are true:
Until all three are satisfied, keep the current 1-reviewer + self-approve configuration to avoid blocking releases on a missing second reviewer.
Refs
Follow-up to #1 A-section.
The
packagingGitHub deployment environment currently has:required_reviewers:inureyes(1 user)prevent_self_review:falsecan_admins_bypass:trueThis means the person who triggers a signing or homebrew-bump deployment can also self-approve it — which provides an "abort window" before the deployment proceeds, but is not a true 4-eyes gate. This was an intentional choice while release tooling was still being automated (see the follow-up note in #1 A-section).
Once the release pipeline is fully automated (manual signing/notarization no longer required, manual homebrew bump no longer required), this configuration should be hardened:
Tasks
inureyes) — discuss in this issue's comments before applyingcan_admins_bypassif org admins should not be able to skip the gategh api repos/lablup/mlxcel/environments/packaging \ --jq '.protection_rules[] | select(.type == "required_reviewers") | {prevent_self_review, reviewer_count: (.reviewers | length)}'prevent_self_review: true,reviewer_count >= 2Triggering conditions
Open this issue for action when all of the following are true:
prevent_self_reviewwould block legitimate releases)Until all three are satisfied, keep the current 1-reviewer + self-approve configuration to avoid blocking releases on a missing second reviewer.
Refs