Merge pull request #217 from labmlai/front-error-handle

only send required data when editing runs

Author: lakshith-403

app/server/labml_app/handlers.py

@@ -285,7 +285,7 @@ async def edit_run(request: Request, run_uuid: str, token: Optional[str] = None)
         data = await request.json()
         r.edit_run(data)
     else:
-        errors.append({'edit_run': 'invalid run uuid'})
+        raise Exception("Invalid Run UUID")
 
     return {'errors': errors}
 

app/ui/src/analyses/experiments/configs/view.ts

@@ -121,7 +121,14 @@ class RunConfigsView extends ScreenView {
             this.save.disabled = true
             this.save.loading = true
             this.configsChanged = false
-            await CACHE.getRun(this.uuid).setRun(this.run)
+
+            let data = {
+                'favourite_configs': this.run.favourite_configs,
+                'selected_configs': this.run.selected_configs
+            }
+
+            await CACHE.getRun(this.uuid).updateRunData(data)
+            await CACHE.getRunsList().localUpdateRun(this.run)
         } catch (e) {
             this.userMessage.networkError(e, "Failed to save configurations")
             this.save.disabled = false

app/ui/src/analyses/experiments/run_header/view.ts

@@ -290,8 +290,16 @@ class RunHeaderView extends ScreenView {
         if (this.noteField.getInput()) {
             this.run.note = this.noteField.getInput()
         }
+
+        let data = {
+            'name': this.run.name,
+            'comment': this.run.comment,
+            'note': this.run.note
+        }
+
         try {
-            await this.runCache.setRun(this.run)
+            await this.runCache.updateRunData(data)
+            await CACHE.getRunsList().localUpdateRun(this.run)
             await this._render()
             this.editStatus = EditStatus.NOCHANGE
         } catch (e) {

app/ui/src/cache/cache.ts

@@ -7,6 +7,7 @@ import {AnalysisPreferenceModel, ComparisonPreferenceModel} from "../models/pref
 import {SessionsList} from '../models/session_list'
 import {Session} from '../models/session'
 import {ProcessData} from "../analyses/sessions/process/types"
+import {Config} from "../models/config"
 
 const RELOAD_TIMEOUT = 60 * 1000
 const FORCE_RELOAD_TIMEOUT = 5 * 1000
@@ -161,6 +162,25 @@ export class RunsListCache extends CacheObject<RunsList> {
         await NETWORK.claimRun(run.run_uuid)
         this.invalidate_cache()
     }
+
+    async localUpdateRun(run: Run) {
+        if (this.data == null) {
+            return
+        }
+
+        for (let runItem of this.data.runs) {
+            if (runItem.run_uuid == run.run_uuid) {
+                runItem.name = run.name
+                runItem.comment = run.comment
+                runItem.favorite_configs = []
+                for (let c of run.configs) {
+                    if (run.favourite_configs.includes(c.name)) {
+                        runItem.favorite_configs.push(new Config(c))
+                    }
+                }
+            }
+        }
+    }
 }
 
 export class SessionsListCache extends CacheObject<SessionsList> {
@@ -230,8 +250,8 @@ export class RunCache extends CacheObject<Run> {
         return this.data
     }
 
-    async setRun(run: Run): Promise<void> {
-        await NETWORK.setRun(this.uuid, run)
+    async updateRunData(data: Record<string, any>): Promise<void> {
+        await NETWORK.updateRunData(this.uuid, data)
     }
 }
 

app/ui/src/network.ts

@@ -21,7 +21,7 @@ class Network {
         return this.sendHttpRequest('GET', `/run/${runUUID}`)['promise']
     }
 
-    async setRun(runUUID: string, data: object): Promise<any> {
+    async updateRunData(runUUID: string, data: object): Promise<any> {
         return this.sendHttpRequest('POST', `/run/${runUUID}`, data)['promise']
     }