Skip to content

Commit 373a601

Browse files
committed
Enhance HTTP status checks in deployment workflow for better response handling
1 parent 66f1ee1 commit 373a601

1 file changed

Lines changed: 10 additions & 8 deletions

File tree

.github/workflows/deploy-app.yml

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ jobs:
4444
4545
HTTP_STATUS="${RESPONSE: -3}"
4646
47-
if [ "$HTTP_STATUS" = "200" ]; then
48-
echo "App '${APP_NAME}' exists"
47+
if [ "$HTTP_STATUS" -ge 200 ] && [ "$HTTP_STATUS" -lt 300 ]; then
48+
echo "App '${APP_NAME}' exists (HTTP $HTTP_STATUS)"
4949
echo "app_exists=true" >> $GITHUB_OUTPUT
5050
echo "existing_app=$(cat /tmp/response.json)" >> $GITHUB_OUTPUT
5151
elif [ "$HTTP_STATUS" = "404" ]; then
@@ -76,8 +76,9 @@ jobs:
7676
7777
HTTP_STATUS="${RESPONSE: -3}"
7878
79-
if [ "$HTTP_STATUS" = "200" ] || [ "$HTTP_STATUS" = "201" ]; then
80-
echo "App updated successfully"
79+
# Check if HTTP status is in success range (200-299) or redirect range (300-399)
80+
if [ "$HTTP_STATUS" -ge 200 ] && [ "$HTTP_STATUS" -lt 400 ]; then
81+
echo "App updated successfully (HTTP $HTTP_STATUS)"
8182
echo "Response: $(cat /tmp/update_response.json)"
8283
else
8384
echo "Error updating app: HTTP $HTTP_STATUS"
@@ -96,8 +97,9 @@ jobs:
9697
9798
HTTP_STATUS="${RESPONSE: -3}"
9899
99-
if [ "$HTTP_STATUS" = "201" ] || [ "$HTTP_STATUS" = "200" ]; then
100-
echo "App created successfully"
100+
# Check if HTTP status is in success range (200-299) or redirect range (300-399)
101+
if [ "$HTTP_STATUS" -ge 200 ] && [ "$HTTP_STATUS" -lt 400 ]; then
102+
echo "App created successfully (HTTP $HTTP_STATUS)"
101103
echo "Response: $(cat /tmp/create_response.json)"
102104
else
103105
echo "Error creating app: HTTP $HTTP_STATUS"
@@ -125,8 +127,8 @@ jobs:
125127
126128
HTTP_STATUS="${RESPONSE: -3}"
127129
128-
if [ "$HTTP_STATUS" = "200" ]; then
129-
echo "App status retrieved successfully"
130+
if [ "$HTTP_STATUS" -ge 200 ] && [ "$HTTP_STATUS" -lt 300 ]; then
131+
echo "App status retrieved successfully (HTTP $HTTP_STATUS)"
130132
131133
# Extract public address and custom domain
132134
PUBLIC_ADDR=$(jq -r '.ports[0].publicAddress // empty' /tmp/app_status.json 2>/dev/null || echo "")

0 commit comments

Comments
 (0)