chore: harden pull request check workflow#28
Open
wallyxjh wants to merge 1 commit into
Open
Conversation
wallyxjh
force-pushed
the
fix/pr-check-workflow-security
branch
from
7517dcc to
9b199b9
Compare
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Hardens the pull_request_target PR check workflow by removing privileged token usage and avoiding executing repository code in a privileged context.
Changes:
- Replaces a third-party branch name action with an inline bash check using
github.head_ref - Removes the PAT-based global token and scopes workflow permissions to read-only issue/PR metadata
- Removes
actions/checkoutand inlines the issue-link check via GitHub CLI GraphQL API
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }} | ||
| permissions: |
| ${{ github.repository_owner }} \ | ||
| ${{ github.event.pull_request.number }} \ | ||
| "${{ github.event.pull_request.title }}" | ||
| if [[ "$PR_TITLE" == chore* || "$PR_TITLE" == docs* ]]; then |
Comment on lines
+66
to
+82
| closingIssuesReferences(first: 10) { | ||
| edges { | ||
| node { | ||
| title | ||
| number | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }' \ | ||
| --jq '.data.repository.pullRequest.closingIssuesReferences.edges' | ||
| )" | ||
|
|
||
| echo "Closing Issues References: $closing_issues_references" | ||
|
|
||
| if [[ "$closing_issues_references" == "[]" ]]; then |
zijiren233
requested changes
May 14, 2026
|
|
||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }} | ||
| permissions: |
Member
There was a problem hiding this comment.
need add contents read permission?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification