fix(main): validate kubeadm config files before pulling images by cuisongliu · Pull Request #5715 · labring/sealos

cuisongliu · 2025-07-22T14:27:24Z

This pull request introduces updates to the sealos project, including enhancements to Kubernetes image pulling logic, the addition of new E2E test cases for Kubernetes versions, and improvements to code structure. Below is a summary of the most important changes:

Kubernetes Image Pulling Enhancements:

Refactored the imagePull method in lifecycle/pkg/runtime/kubernetes/master.go to dynamically fetch and modify Kubernetes image lists before pulling them. This includes parsing image lists in JSON format, replacing registry domains, and using crictl for pulling images.
Introduced new imports for handling JSON parsing and registry domain management, such as k8s.io/apimachinery/pkg/util/json and github.com/labring/sreg/pkg/registry/crane.

E2E Test Additions:

Added E2E test cases for Kubernetes versions v1.29.0, v1.30.0, v1.31.0, and v1.32.0 for both containerd and docker runtimes. These tests verify cluster creation, image application, and cleanup processes. [1] [2] [3] [4] [5] [6] [7] [8]
Updated the .github/workflows/e2e_test_core.yml file to include the new test cases in the CI pipeline.

Code Structure Improvements:

Replaced the usage of strings utility functions with str2 (aliased import of github.com/labring/sealos/pkg/utils/strings) in lifecycle/pkg/runtime/kubernetes/master.go to avoid naming conflicts and improve clarity. [1] [2]

These changes enhance the functionality, test coverage, and maintainability of the sealos project.

#5653

The new version does not support the --cri-socket parameter and needs to be adjusted using --config.
Test version 1.31+ tested.
Need to test the low version

gru-agent · 2025-07-22T14:27:35Z

TestGru Assignment

Summary

Link	CommitId	Status	Reason
Detail	`28583f7`	✅ Finished

History Assignment

Files

File	Pull Request
lifecycle/pkg/runtime/kubernetes/master.go	🟢 Open #5716

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

…29.0 to 1.32.0 Signed-off-by: cuisongliu <cuisongliu@qq.com>

cuisongliu · 2025-07-22T16:25:51Z

Signed-off-by: cuisongliu <cuisongliu@qq.com>

cuisongliu · 2025-07-24T03:13:06Z

…ng#5715) * fix(main): validate kubeadm config files before pulling images * test(e2e): add end-to-end tests for Kubernetes and Docker versions 1.29.0 to 1.32.0 Signed-off-by: cuisongliu <cuisongliu@qq.com> * fix(main): update image pulling logic and refactor string utilities Signed-off-by: cuisongliu <cuisongliu@qq.com> --------- Signed-off-by: cuisongliu <cuisongliu@qq.com>

* Commit * fix conflict * commit container * delete container * stdout * Gc Handler * ctx unit test * fix(main): validate kubeadm config files before pulling images (labring#5715) * fix(main): validate kubeadm config files before pulling images * test(e2e): add end-to-end tests for Kubernetes and Docker versions 1.29.0 to 1.32.0 Signed-off-by: cuisongliu <cuisongliu@qq.com> * fix(main): update image pulling logic and refactor string utilities Signed-off-by: cuisongliu <cuisongliu@qq.com> --------- Signed-off-by: cuisongliu <cuisongliu@qq.com> * add pods limit, default: 20 (labring#5724) * Update LICENSE (labring#5719) * Update LICENSE * Update LICENSE * feat(launchpad): new custom domain form (labring#5701) * feat(launchpad): new custom domain form Signed-off-by: Nixieboluo <me@sagirii.me> * feat(launchpad): automatically refresh cname every 5 secs Signed-off-by: Nixieboluo <me@sagirii.me> * feat(launchpad): add i18n for custom domain binding form Signed-off-by: Nixieboluo <me@sagirii.me> * fix(launchpad): change colors of custom domain binding form to match the design Signed-off-by: Nixieboluo <me@sagirii.me> * fix(launchpad): add missing default export for DomainNotBoundModel Signed-off-by: Nixieboluo <me@sagirii.me> * chore(launchpad): add missing config examples Signed-off-by: Nixieboluo <me@sagirii.me> * feat(launchpad): use modern clipboard api for copying data Signed-off-by: Nixieboluo <me@sagirii.me> * fix(launchpad): move hardcoded domain reg link to i18n file Signed-off-by: Nixieboluo <me@sagirii.me> * refactor(launchpad): use underscore in i18n keys Signed-off-by: Nixieboluo <me@sagirii.me> * feat(launchpad): design & ux catchup for domain verif form Signed-off-by: Nixieboluo <me@sagirii.me> * fix(launchpad): clear button on domain verif form Signed-off-by: Nixieboluo <me@sagirii.me> * feat(launchpad): add a link for domain reg docs Signed-off-by: Nixieboluo <me@sagirii.me> --------- Signed-off-by: Nixieboluo <me@sagirii.me> * feat(desktop): desktop design catchup (labring#5703) * feat(desktop): match app grid and folder design with design Signed-off-by: Nixieboluo <me@sagirii.me> * feat(desktop): make folder draw area larger Signed-off-by: Nixieboluo <me@sagirii.me> * refactor(desktop): calculate app height using the height of 2 lines app name Signed-off-by: Nixieboluo <me@sagirii.me> * feat(desktop): add menu for secondary links on narrow screens Signed-off-by: Nixieboluo <me@sagirii.me> * chore(desktop): clean up Signed-off-by: Nixieboluo <me@sagirii.me> * feat(desktop): tweak pin input corner radius to match the design Signed-off-by: Nixieboluo <me@sagirii.me> * fix(desktop): incorrect desktop folder paging calculation Signed-off-by: Nixieboluo <me@sagirii.me> * fix(desktop): navbar overflows on very narrow screens Signed-off-by: Nixieboluo <me@sagirii.me> --------- Signed-off-by: Nixieboluo <me@sagirii.me> * feat(devbox): v2 ui and code refactor (labring#5686) * fix:chart tooltip * feat: loading component * chore: remove unused ui * feat: devbox name runtime tooltip * fix: list pagination auto reset bug * feat: devbox create left side * feat: yaml page * fix: scrollbar color change * feat: devbox create * refactor: chakra to shadcn(detail related) * fix: IDE show bug * feat: devbox detail header * fix: detail header position * feat: detail sidebar * feat: detail basic * feat: detail live monitoring * feat: detail network * feat: detail layout adjust * fix: layout fix again * feat: detail release * feat: deploy modal * feat: detail adjust layout * feat: shutdown modal and release modal * fix: appSelectModal background image * feat: toolbox and sshConnect drawer * chore: remove some unused code * chore: jb modal chakra to shadcn * feat: deleteDevboxModal * chore: adjust some code * feat: template layout * feat: template left sidebar * feat: public template mainBody * feat: createOrUpdate drawer * feat: create template * fix: react html bug * feat: template update template * feat: private template * feat: private template * feat: jetbrain ide * feat: deploy devbox drawer * chore: remove unused template code * chore: remove unused icon code * fix: little fix * feat: create template time * feat: create devbox template part * chore: remove unused code * fix: release show bug * fix: detail height bug * fix: detail padding bug * fix: detail basic event style bug * fix: some ts-lint bug * fix: detail layout bug * chore: remove unused code * fix: update devbox bug * fix: create and update devbox navigate bug * chore: adjust file structure * fix: ts bug * feat: detail layout sidebar * feat: detail page * feat: datapciker * fix: date-picker style adjust * fix: idebutton rerender bug * fix: some style adjust * fix: detail layout style bug * fix: date picker bug * feat: monitor chart * feat: refresh button * feat: monitor page fully * fix: list fix * fix: bug * fix: lower case and upper case * fix: style fix * fix: template card style * fix: bug * fix: create route bug * fix: style adjust * fix: adjust style * feat: guide * fix: adjust style * fix: time show bug * fix: bug * fix: template empty show bug * fix: bug * style: monitor chart color * feat: devbox list template name * style: adjust style * feat: create devbox port add * fix: style adjust * style: padding adjust * fix: bug * fix: style adjust * fix: style adjust * chore: update env file * fix: coin logic bug * fix: delete some unused ui * fix: some no little bug * fix: bug * fix: little style bug * fix: network show bug * fix: style adjust * fix: style bug * fix: icon bug * fix: handle back bug * fix: template bug * fix: toggle tag bug * chore: adjust typo * fix: style adjust * feat: adjust detail style * fix: monitor style adjust * fix: some little bug * chore: remove unused code * fix: template create and update bug * fix: template version bug * fix: release devbox version bug * fix: style adjust * chore: add tailwindcss and shadcn * fix: tailwindcss v4 update bug * chore: add some useful ui * fix: deal prettier and eslint bug * chore: adjust layout.tsx * chore: add some comment * chore: remove unused code * chore: remove chakra-ui * feat: font inter->geist * feat: list page basic * style: some little p fix * feat: list pagination * fix:chart tooltip * feat: loading component * chore: remove unused ui * feat: devbox name runtime tooltip * fix: list pagination auto reset bug * feat: devbox create left side * feat: yaml page * fix: scrollbar color change * feat: devbox create * refactor: chakra to shadcn(detail related) * fix: IDE show bug * feat: devbox detail header * fix: detail header position * feat: detail sidebar * feat: detail basic * feat: detail live monitoring * feat: detail network * feat: detail layout adjust * fix: layout fix again * feat: detail release * feat: deploy modal * feat: detail adjust layout * feat: shutdown modal and release modal * fix: appSelectModal background image * feat: toolbox and sshConnect drawer * chore: remove some unused code * chore: jb modal chakra to shadcn * feat: deleteDevboxModal * chore: adjust some code * feat: template layout * feat: template left sidebar * feat: public template mainBody * feat: createOrUpdate drawer * feat: create template * fix: react html bug * feat: template update template * feat: private template * feat: private template * feat: jetbrain ide * feat: deploy devbox drawer * chore: remove unused template code * chore: remove unused icon code * fix: little fix * feat: create template time * feat: create devbox template part * chore: remove unused code * fix: release show bug * fix: detail height bug * fix: detail padding bug * fix: detail basic event style bug * fix: some ts-lint bug * fix: detail layout bug * chore: remove unused code * fix: update devbox bug * fix: create and update devbox navigate bug * chore: adjust file structure * fix: ts bug * feat: detail layout sidebar * feat: detail page * feat: datapciker * fix: date-picker style adjust * fix: idebutton rerender bug * fix: some style adjust * fix: detail layout style bug * fix: date picker bug * feat: monitor chart * feat: refresh button * feat: monitor page fully * fix: list fix * fix: bug * fix: lower case and upper case * fix: style fix * fix: template card style * fix: bug * fix: create route bug * fix: style adjust * fix: adjust style * feat: guide * fix: adjust style * fix: time show bug * fix: bug * fix: template empty show bug * fix: bug * style: monitor chart color * feat: devbox list template name * style: adjust style * feat: create devbox port add * fix: style adjust * style: padding adjust * fix: bug * fix: style adjust * fix: style adjust * chore: update env file * fix: coin logic bug * fix: delete some unused ui * fix: some no little bug * fix: bug * fix: little style bug * fix: network show bug * fix: style adjust * fix: style bug * fix: icon bug * fix: handle back bug * fix: template bug * fix: toggle tag bug * chore: adjust typo * fix: style adjust * feat: adjust detail style * fix: monitor style adjust * fix: some little bug * chore: remove unused code * fix: template create and update bug * fix: template version bug * fix: release devbox version bug * fix: style adjust * chore: add network limit * feat: hide log * fix: style bug * fix: yaml typo bug * chore: document url not hard-coding * chore: reference path ->api-docs * add commit err * add commit err * add runtime * init committer * new create func * new remove container func --------- Signed-off-by: cuisongliu <cuisongliu@qq.com> Signed-off-by: Nixieboluo <me@sagirii.me> Co-authored-by: Cunzili <cunzili@CunzilideMacBook-Pro.local> Co-authored-by: cuisongliu <cuisongliu@qq.com> Co-authored-by: Jiahui <4543bxy@gmail.com> Co-authored-by: fanux <fanux@sealos.io> Co-authored-by: Nixieboluo <me@sagirii.me> Co-authored-by: Alex Lee <3076438032@qq.com>

feeyman · 2025-08-21T03:31:48Z

@cuisongliu Hello, I recently upgraded k8s and encountered this deployment issue. I am very happy to see that the experts have fixed the bug. Will a version be released soon? Looking forward to a reply.

cuisongliu · 2025-08-21T10:09:53Z

@cuisongliu Hello, I recently upgraded k8s and encountered this deployment issue. I am very happy to see that the experts have fixed the bug. Will a version be released soon? Looking forward to a reply.

Yes, I have been preparing for the release of the new version recently, and the v5.1.0-beta1 version will be released in the near future. Of course, there will be some small problems, but the high version of k8s （v1.30+） must be supported first. Wait patiently.

feeyman · 2025-08-22T01:25:14Z

@cuisongliu Hello, I recently upgraded k8s and encountered this deployment issue. I am very happy to see that the experts have fixed the bug. Will a version be released soon? Looking forward to a reply.

Yes, I have been preparing for the release of the new version recently, and the v5.1.0-beta1 version will be released in the near future. Of course, there will be some small problems, but the high version of k8s （v1.30+） must be supported first. Wait patiently.

### Thank you for your reply. Yes, as you said, the new code has fixed the bug and the 1.33.3 version of k8s has been successfully deployed. Thank you very much, it's really timely.

pull-request-size bot added the size/S label Jul 22, 2025

github-actions bot added area/lifecycle-management area/runtime labels Jul 22, 2025

cuisongliu mentioned this pull request Jul 22, 2025

fix:Unimplemented RuntimeService error while installing high version k8s #5653

Closed

fix(main): validate kubeadm config files before pulling images

d923553

cuisongliu force-pushed the fix-image-pull-new-version branch from 28583f7 to d923553 Compare July 22, 2025 14:35

gru-agent bot mentioned this pull request Jul 22, 2025

test: Add unit test for lifecycle/pkg/runtime/kubernetes/master.go #5716

Closed

test(e2e): add end-to-end tests for Kubernetes and Docker versions 1.…

b88a50e

…29.0 to 1.32.0 Signed-off-by: cuisongliu <cuisongliu@qq.com>

pull-request-size bot added size/L and removed size/S labels Jul 22, 2025

github-actions bot added area/test area/workflow labels Jul 22, 2025

cuisongliu marked this pull request as draft July 22, 2025 15:54

cuisongliu force-pushed the fix-image-pull-new-version branch 3 times, most recently from aec116f to fa3f32d Compare July 22, 2025 17:11

cuisongliu marked this pull request as ready for review July 22, 2025 17:19

cuisongliu force-pushed the fix-image-pull-new-version branch 2 times, most recently from f0e38bc to d12cf1c Compare July 23, 2025 02:09

fix(main): update image pulling logic and refactor string utilities

e15b2c8

Signed-off-by: cuisongliu <cuisongliu@qq.com>

cuisongliu force-pushed the fix-image-pull-new-version branch from d12cf1c to e15b2c8 Compare July 23, 2025 02:43

This was linked to issues Jul 23, 2025

BUG: image pull failed #5577

Closed

离线部署sealos，镜像拉取失败导致部署失败 #5637

Closed

sealos部署k8s v1.32.5集群错误 #5644

Closed

cuisongliu self-assigned this Jul 23, 2025

cuisongliu linked an issue Jul 24, 2025 that may be closed by this pull request

BUG: failed to init masters: master pull image failed #5677

Closed

lingdie approved these changes Jul 24, 2025

View reviewed changes

cuisongliu merged commit b459a0d into labring:main Jul 24, 2025
85 of 87 checks passed

cuisongliu deleted the fix-image-pull-new-version branch July 24, 2025 06:47

This was referenced Jul 30, 2025

BUG: deploy k8s cluster failed #5688

Closed

BUG: sealos自定义安装，k8s版本v1.33.1部署集群失败 #5642

Closed

The latest version ( v5.0.1 ) of the sealos deployment k8s will fail due to a public image pull #5638

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(main): validate kubeadm config files before pulling images#5715

fix(main): validate kubeadm config files before pulling images#5715
cuisongliu merged 3 commits intolabring:mainfrom
cuisongliu:fix-image-pull-new-version

cuisongliu commented Jul 22, 2025 •

edited

Loading

Uh oh!

gru-agent bot commented Jul 22, 2025 •

edited

Loading

Uh oh!

cuisongliu commented Jul 22, 2025

Uh oh!

cuisongliu commented Jul 24, 2025

Uh oh!

Uh oh!

feeyman commented Aug 21, 2025

Uh oh!

cuisongliu commented Aug 21, 2025

Uh oh!

feeyman commented Aug 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

cuisongliu commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Kubernetes Image Pulling Enhancements:

E2E Test Additions:

Code Structure Improvements:

Uh oh!

gru-agent bot commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TestGru Assignment

Summary

Files

Uh oh!

cuisongliu commented Jul 22, 2025

Uh oh!

cuisongliu commented Jul 24, 2025

Uh oh!

Uh oh!

feeyman commented Aug 21, 2025

Uh oh!

cuisongliu commented Aug 21, 2025

Uh oh!

feeyman commented Aug 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cuisongliu commented Jul 22, 2025 •

edited

Loading

gru-agent bot commented Jul 22, 2025 •

edited

Loading