Skip to content

Units #22

Open
Open
@philipstarkey

Description

@philipstarkey

Original report (archived issue) by Shaun Johnstone (Bitbucket: shjohnst, GitHub: shjohnst).


As far as I can tell, units are not yet implemented in runviewer. There are a couple of lines of code that try to set the units of the y-axis, but this does not seem to be fully implemented yet. Given that we have fancy unit conversions in BLACS, it would make sense to try to implement them in runviewer too! In almost all cases it would be more sensible to plot in a converted unit rather than the base, e.g. plot coil traces in amps, not volts on the control line, or AOM frequencies in MHz detuned from an atomic line, not Hz.

I'm not sure what the best way to incorporate this into to GUI would be. Perhaps the easiest would be to include a selector box next to each channel in the list of channels in the lower left pane, rather than trying to have it incorporated into the graph y-axis. Then the values would have to be passed through the appropriate unit conversion class to generate the data to be plotted.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions