Skip to content

Commit 94b5f80

Browse files
authored
cookbook: apply review suggestions from #443 (#467)
Log "read" on the read path of the net websocket example (the docs page renders this file), and use a deferred server.Close() in its test, matching the gorilla test. Follow-up to #443 by @wakqasahmed. Claude-Session: https://claude.ai/code/session_01QKDYQr53zNKkR7nif2CAAq
1 parent 7b8ed71 commit 94b5f80

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

‎cookbook/websocket/net/server.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ func hello(c *echo.Context) error {
2222
// Read
2323
msg := ""
2424
if err := websocket.Message.Receive(ws, &msg); err != nil {
25-
c.Logger().Error("failed to write WS message", "error", err)
25+
c.Logger().Error("failed to read WS message", "error", err)
2626
return
2727
}
2828
fmt.Printf("%s\n", msg)

‎cookbook/websocket/net/server_test.go‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,20 +22,19 @@ func TestHelloReturnsAfterClientDisconnect(t *testing.T) {
2222
})
2323

2424
server := httptest.NewServer(e)
25+
defer server.Close()
26+
2527
wsURL := "ws" + strings.TrimPrefix(server.URL, "http") + "/ws"
2628
ws, err := websocket.Dial(wsURL, "", server.URL)
2729
if err != nil {
28-
server.Close()
2930
t.Fatalf("failed to connect websocket client: %v", err)
3031
}
3132
if err := ws.Close(); err != nil {
32-
server.CloseClientConnections()
3333
t.Fatalf("failed to close websocket client: %v", err)
3434
}
3535

3636
select {
3737
case <-handlerReturned:
38-
server.Close()
3938
case <-time.After(2 * time.Second):
4039
t.Fatal("websocket handler did not return after client disconnected")
4140
}

0 commit comments

Comments
 (0)