Merge pull request #1805 from perrin4869/fix/ipv6-addresses

fix: ipv6 addresses parsing

Author: titanism

src/node/index.js

@@ -754,7 +754,7 @@ Request.prototype.request = function () {
   options.method = this.method;
   options.port = url.port;
   options.path = path;
-  options.host = url.hostname;
+  options.host = utils.normalizeHostname(url.hostname); // ex: [::1] -> ::1
   options.ca = this._ca;
   options.key = this._key;
   options.pfx = this._pfx;

src/utils.js

@@ -72,6 +72,11 @@ exports.cleanHeader = (header, changesOrigin) => {
   return header;
 };
 
+exports.normalizeHostname = (hostname) => {
+  const [,normalized] = hostname.match(/^\[([^\]]+)\]$/) || [];
+  return normalized || hostname;
+};
+
 /**
  * Check if `obj` is an object.
  *

test/node/basic.js

@@ -134,6 +134,24 @@ describe('[node] request', () => {
     });
   });
 
+  if (doesntWorkInHttp2) {
+    describe('ipv6 address', () => {
+      it('should successfully query an ipv6 address', (done) => {
+        request.get(`http://[::]:${process.env.ZUUL_PORT}/url?a=(b%29`).end((error, res) => {
+          assert.equal('/url?a=(b%29', res.text);
+          done();
+        });
+      });
+
+      it('should successfully query an ipv6 address', (done) => {
+        request.get(`http://[::1]:${process.env.ZUUL_PORT}/url?a=(b%29`).end((error, res) => {
+          assert.equal('/url?a=(b%29', res.text);
+          done();
+        });
+      });
+    });
+  }
+
   describe('.buffer()', () => {
     it('should enable buffering', (done) => {
       request