fix(polygon): Catch edge case where self-intersecting reads as convex

Author: chriswmackey

ladybug_geometry/geometry2d/polygon.py

@@ -404,17 +404,16 @@ def is_self_intersecting(self):
         """
         if self._is_self_intersecting is None:
             self._is_self_intersecting = False
-            if self.is_convex is False:
-                _segs = self.segments
-                for i, _s in enumerate(_segs[1: len(_segs) - 1]):
-                    _skip = (i, i + 1, i + 2)
-                    _other_segs = [x for j, x in enumerate(_segs) if j not in _skip]
-                    for _oth_s in _other_segs:
-                        if _s.intersect_line_ray(_oth_s) is not None:  # intersection!
-                            self._is_self_intersecting = True
-                            break
-                    if self._is_self_intersecting is True:
+            _segs = self.segments
+            for i, _s in enumerate(_segs[1: len(_segs) - 1]):
+                _skip = (i, i + 1, i + 2)
+                _other_segs = [x for j, x in enumerate(_segs) if j not in _skip]
+                for _oth_s in _other_segs:
+                    if _s.intersect_line_ray(_oth_s) is not None:  # intersection!
+                        self._is_self_intersecting = True
                         break
+                if self._is_self_intersecting is True:
+                    break
         return self._is_self_intersecting
 
     @property

tests/polygon2d_test.py

@@ -259,6 +259,23 @@ def test_is_self_intersecting():
     assert polygon_2.is_self_intersecting
 
 
+def test_is_self_intersecting_complex_clockwise():
+    """Test the is_self_intersecting property on a more complex shape."""
+    pts_3 = (
+        (355.665006, -49.844883),
+        (298.354434, 4.142452),
+        (280.207456, 59.649202),
+        (336.988767, 88.694148),
+        (348.680933, 44.475185),
+        (342.255592, 52.129292),
+        (373.115776, 106.898085),
+        (421.261481, 55.706056),
+        (355.665006, -49.844883)
+    )
+    polygon = Polygon2D.from_array(pts_3)
+    assert polygon.is_self_intersecting
+
+
 def test_is_valid():
     """Test the is_valid property."""
     pts_1 = (Point2D(0, 0), Point2D(2, 0), Point2D(2, 2))