mention NODE_ENV as build and prod run environment, fix type issues

Author: laidrivm

package.json

@@ -33,14 +33,14 @@
   "scripts": {
     "format": "prettier --write 'src/**/*.{css,html,ts,tsx}'",
     "lint": "eslint 'src/**/*.{css,html,ts,tsx}' --fix",
-    "build": "bun run build.ts",
+    "build": "NODE_ENV=production bun run build.ts",
     "test": "bun test --watch --timeout 1000 --rerun-each 2 --coverage",
-    "generate_dev": "bun src/generate.tsx",
-    "server_dev": "bun run --watch src/index.ts",
-    "dev": "bun run --env-file=.env.development build && bun run generate_dev && bun run server_dev",
+    "generate_dev": "bun run --env-file=.env.development src/generate.tsx",
+    "server_dev": "bun run --env-file=.env.development --watch src/index.ts",
+    "dev": "bun generate_dev && bun run server_dev",
     "generate": "bun run out/generate.js",
     "server": "bun run out/index.js",
-    "prod": "bun run generate && bun run server",
+    "prod": "NODE_ENV=production bun run generate && bun run server",
     "clean": "bun run src/public-clean-up.ts"
   }
 }

src/generate.tsx

@@ -44,7 +44,8 @@ ${urls}
  * Clean up articles directory after processing
  * @param articlesPath Path to articles directory
  */
-async function cleanupArticlesDirectory(articlesPath: string): Promise<void> {
+async function cleanupArticlesDirectory(): Promise<void> {
+  const articlesPath = process.env.ARTICLES
   try {
     await rm(articlesPath, {recursive: true})
   } catch (error) {

src/pullarticles.ts

@@ -88,7 +88,7 @@ async function processRepoContents(
   octokit: Octokit,
   owner: string,
   repo: string,
-  repoPath = '',
+  repoPath: string,
   articlesDir: string
 ): Promise<void> {
   try {
@@ -129,7 +129,7 @@ async function pullArticles(): Promise<void> {
   try {
     const octokit = createOctokitClient(process.env.GITHUB_TOKEN)
     const {owner, repo} = parseRepoDetails(process.env.SOURCE)
-    const articlesDir = resolvePath(process.cwd(), process.env.ARTICLE)
+    const articlesDir = resolvePath(process.cwd(), process.env.ARTICLES)
 
     await fs.mkdir(articlesDir, {recursive: true})
     await processRepoContents(octokit, owner, repo, '', articlesDir)