Replace deprecated Gtk widgets and dialogs with modern alternatives

- Switch from GtkComboBoxText to GtkDropDown in preferences UI
- Replace Gtk.MessageDialog with Gtk.AlertDialog for alerts
- Remove deprecated dialog wrappers in DialogUtils
- Update sidebar file removal to use Gtk.AlertDialog
- Remove debug print statements and unused Gtk.Box children
- Refactor preferences logic for new dropdowns
- Simplify async error handling in WebView update

Author: lainsce

data/ui/prefs_window.ui

@@ -15,12 +15,7 @@
               <object class="HeSettingsRow">
                 <property name="title">Font Type</property>
                 <child>
-                    <object class="GtkComboBoxText" id="font_type">
-                        <items>
-                            <item translatable="yes">Quilt Mono</item>
-                            <item translatable="yes">Quilt Zwei</item>
-                            <item translatable="yes">Quilt Vier</item>
-                        </items>
+                    <object class="GtkDropDown" id="font_type">
                     </object>
                 </child>
               </object>
@@ -139,12 +134,7 @@
               <object class="HeSettingsRow">
                 <property name="title">Preview Font Type</property>
                 <child>
-                    <object class="GtkComboBoxText" id="preview_font_type">
-                        <items>
-                        <item translatable="yes">Serif</item>
-                        <item translatable="yes">Sans-serif</item>
-                        <item translatable="yes">Monospace</item>
-                        </items>
+                    <object class="GtkDropDown" id="preview_font_type">
                     </object>
                 </child>
               </object>

data/ui/sidebar.ui

@@ -145,16 +145,13 @@
   </object>
   <template class="QuilterWidgetsSideBar" parent="HeBin">
     <property name="vexpand">1</property>
-    <property name="hexpand">0</property>
-    <property name="width-request">270</property>
     <child>
       <object class="GtkBox" id="navbox">
         <child>
           <object class="GtkBox">
             <property name="orientation">vertical</property>
             <child>
               <object class="HeAppBar">
-                <property name="width-request">113</property>
               </object>
             </child>
             <child>
@@ -167,6 +164,7 @@
         <child>
           <object class="HeSideBar" id="flap">
             <property name="has-margins">0</property>
+            <property name="width-request">280</property>
             <property name="show-left-title-buttons">0</property>
             <property name="vexpand">1</property>
             <property name="hexpand">1</property>

src/Application.vala

@@ -169,13 +169,9 @@ namespace Quilter {
                     // Notify the user that something happened.
                     if (msg.length > 0) {
                         var parent_win = get_last_win () as Gtk.Window;
-                        var dialog = new Gtk.MessageDialog (parent_win,
-                                                            Gtk.DialogFlags.MODAL,
-                                                            Gtk.MessageType.WARNING,
-                                                            Gtk.ButtonsType.CLOSE,
-                                                            msg);
-                        dialog.show ();
-                        dialog.close ();
+                        var alert = new Gtk.AlertDialog (msg);
+                        alert.set_modal (true);
+                        alert.show (parent_win);
                     }
                 }
 

src/MainWindow.vala

@@ -244,10 +244,10 @@ namespace Quilter {
 
         private void setup_signals () {
             Quilter.Application.gsettings.changed.connect (on_settings_changed);
-            appbar.open.connect (() => { print ("DEBUG: open clicked\n"); on_open (); });
-            appbar.save.connect (() => { print ("DEBUG: save clicked\n"); on_save (); });
-            appbar.save_as.connect (() => { print ("DEBUG: save_as clicked\n"); on_save_as (); });
-            appbar.create_new.connect (() => { print ("DEBUG: new clicked\n"); on_create_new (); });
+            appbar.open.connect (on_open);
+            appbar.save.connect (on_save);
+            appbar.save_as.connect (on_save_as);
+            appbar.create_new.connect (on_create_new);
             appbar.preview_toggled.connect (on_preview_toggled);
             toggle_sidebar.connect (on_toggle_sidebar);
             focus_overlay_button.clicked.connect (() => {
@@ -521,7 +521,6 @@ namespace Quilter {
         }
 
         private void on_create_new () {
-            print ("DEBUG: on_create_new()\n");
             create_new_document ();
             file_manager.save_open_files (this);
         }
@@ -543,26 +542,19 @@ namespace Quilter {
         }
 
         private void on_open () {
-            print ("DEBUG: on_open()\n");
             on_open_async.begin ((obj, res) => {
-                try {
-                    on_open_async.end (res);
-                } catch (Error e) {
-                    warning ("Error in open operation: %s", e.message);
-                }
+                on_open_async.end (res);
             });
         }
 
         private async void on_open_async () {
-            print ("DEBUG: on_open_async() start\n");
             if (is_opening)return;
             is_opening = true;
 
             try {
                 var result = yield file_manager.open (this);
-                
+
                 if (result == null) {
-                    print ("DEBUG: open canceled or null result\n");
                     is_opening = false;
                     return;
                 }
@@ -593,7 +585,6 @@ namespace Quilter {
         }
 
         private void on_save () {
-            print ("DEBUG: on_save()\n");
             unowned Widgets.SideBarBox? row = sidebar.get_selected_row ();
             if (row == null) {
                 // Fallback to current-file if no row is selected
@@ -614,7 +605,6 @@ namespace Quilter {
             try {
                 // If this is a temp/unsaved file, route to Save As
                 if (file_manager.is_temp_file (row.path)) {
-                    print ("DEBUG: on_save() -> temp file, delegating to Save As\n");
                     on_save_as ();
                     return;
                 }
@@ -632,18 +622,12 @@ namespace Quilter {
         }
 
         private void on_save_as () {
-            print ("DEBUG: on_save_as()\n");
             on_save_as_async.begin ((obj, res) => {
-                try {
-                    on_save_as_async.end (res);
-                } catch (Error e) {
-                    warning ("Error in save as operation: %s", e.message);
-                }
+                on_save_as_async.end (res);
             });
         }
 
         private async void on_save_as_async () {
-            print ("DEBUG: on_save_as_async() start\n");
             unowned Widgets.SideBarBox? row = sidebar.get_selected_row ();
             if (row == null) {
                 // Fallback to current-file if no row is selected
@@ -665,7 +649,6 @@ namespace Quilter {
                 string new_path = yield file_manager.save_as (edit_view_content.text, this);
 
                 if (new_path != "") {
-                    print ("DEBUG: save_as -> new path: %s\n", new_path);
                     edit_view_content.modified = false;
                     update_samenu_title (new_path);
                     row.path = new_path;

src/Services/DialogUtils.vala

@@ -47,57 +47,5 @@ namespace Quilter.Services.DialogUtils {
         return response;
     }
 
-    public class Dialog : He.Bin {
-        public MainWindow win { get; construct; }
-        public Gtk.MessageDialog dialog;
-
-        public Dialog (MainWindow win) {
-            Object (win: win);
-
-            dialog = new Gtk.MessageDialog (
-                                            win,
-                                            Gtk.DialogFlags.MODAL | Gtk.DialogFlags.DESTROY_WITH_PARENT,
-                                            Gtk.MessageType.QUESTION,
-                                            Gtk.ButtonsType.NONE,
-                                            _("Save Open File?")
-            );
-
-            dialog.secondary_text = _("There are unsaved changes to the file, any changes will be lost if not saved.");
-
-            dialog.add_button (_("Cancel"), Gtk.ResponseType.CANCEL);
-            dialog.add_button (_("Close Without Saving"), Gtk.ResponseType.REJECT);
-            dialog.add_button (_("Save"), Gtk.ResponseType.ACCEPT);
-
-            dialog.set_default_response (Gtk.ResponseType.ACCEPT);
-
-            this.child = dialog;
-        }
-    }
-
-    public class Dialog2 : He.Bin {
-        public MainWindow win { get; construct; }
-        public Gtk.MessageDialog dialog;
-
-        public Dialog2 (MainWindow win) {
-            Object (win: win);
-
-            dialog = new Gtk.MessageDialog (
-                                            win,
-                                            Gtk.DialogFlags.MODAL | Gtk.DialogFlags.DESTROY_WITH_PARENT,
-                                            Gtk.MessageType.QUESTION,
-                                            Gtk.ButtonsType.NONE,
-                                            _("Remove File From Sidebar?")
-            );
-
-            dialog.secondary_text = _("By removing this file from the Sidebar, any changes will be lost if not saved.");
-
-            dialog.add_button (_("Cancel"), Gtk.ResponseType.CANCEL);
-            dialog.add_button (_("Remove Without Saving"), Gtk.ResponseType.REJECT);
-            dialog.add_button (_("Save"), Gtk.ResponseType.ACCEPT);
-
-            dialog.set_default_response (Gtk.ResponseType.ACCEPT);
-
-            this.child = dialog;
-        }
-    }
+    // Note: Deprecated MessageDialog wrappers were removed.
 }

src/Widgets/Preferences.vala

@@ -20,7 +20,7 @@ namespace Quilter {
     [GtkTemplate (ui = "/io/github/lainsce/Quilter/prefs_window.ui")]
     public class Widgets.Preferences : He.SettingsWindow {
         [GtkChild]
-        unowned Gtk.ComboBoxText font_type;
+        unowned Gtk.DropDown font_type;
         [GtkChild]
         unowned Gtk.Switch autosave;
         [GtkChild]
@@ -34,7 +34,7 @@ namespace Quilter {
         [GtkChild]
         public unowned Gtk.CheckButton scope_sentence;
         [GtkChild]
-        unowned Gtk.ComboBoxText preview_font_type;
+        unowned Gtk.DropDown preview_font_type;
         [GtkChild]
         unowned Gtk.Switch center;
         [GtkChild]
@@ -53,14 +53,26 @@ namespace Quilter {
         }
 
         private void preferences_connect () {
-            font_type.active = Quilter.Application.gsettings.get_enum ("edit-font");
-            font_type.changed.connect (() => {
-                Quilter.Application.gsettings.set_enum ("edit-font", font_type.active);
+            // Editor font type dropdown
+            var edit_list = new Gtk.StringList (null);
+            edit_list.append ("Quilt Mono");
+            edit_list.append ("Quilt Zwei");
+            edit_list.append ("Quilt Vier");
+            font_type.set_model (edit_list);
+            font_type.selected = (uint) Quilter.Application.gsettings.get_enum ("edit-font");
+            font_type.notify["selected"].connect (() => {
+                Quilter.Application.gsettings.set_enum ("edit-font", (int) font_type.selected);
             });
 
-            preview_font_type.active = Quilter.Application.gsettings.get_enum ("preview-font");
-            preview_font_type.changed.connect (() => {
-                Quilter.Application.gsettings.set_enum ("preview-font", preview_font_type.active);
+            // Preview font type dropdown
+            var prev_list = new Gtk.StringList (null);
+            prev_list.append ("Serif");
+            prev_list.append ("Sans-serif");
+            prev_list.append ("Monospace");
+            preview_font_type.set_model (prev_list);
+            preview_font_type.selected = (uint) Quilter.Application.gsettings.get_enum ("preview-font");
+            preview_font_type.notify["selected"].connect (() => {
+                Quilter.Application.gsettings.set_enum ("preview-font", (int) preview_font_type.selected);
             });
 
             scope_paragraph.toggled.connect (() => {

src/Widgets/SearchBar.vala

@@ -39,10 +39,6 @@ namespace Quilter {
 
         [GtkChild]
         public unowned Gtk.Revealer searchbar;
-        [GtkChild]
-        private unowned Gtk.Box box1;
-        [GtkChild]
-        private unowned Gtk.Box box2;
 
         public GtkSource.SearchContext search_context = null;
         public weak MainWindow window { get; construct; }

src/Widgets/SideBar.vala

@@ -329,37 +329,39 @@ namespace Quilter.Widgets {
         }
 
         private void remove_file (SideBarBox box) {
-            var dialog = new Gtk.MessageDialog (win,
-                                                Gtk.DialogFlags.MODAL,
-                                                Gtk.MessageType.QUESTION,
-                                                Gtk.ButtonsType.YES_NO,
-                                                _("Remove this file from the sidebar?"));
-            dialog.secondary_text = _("This will not delete the file from your computer.");
-
-            dialog.response.connect ((response) => {
-                if (response == Gtk.ResponseType.YES) {
-                    column.remove (box);
-
-                    // Select next available row
-                    var next_row = column.get_selected_row ();
-                    if (next_row == null) {
-                        next_row = column.get_row_at_index (0);
-                    }
+            var alert = new Gtk.AlertDialog (_("Remove this file from the sidebar?"));
+            alert.set_detail (_("This will not delete the file from your computer."));
+            alert.set_modal (true);
+            alert.set_buttons ({ _("Cancel"), _("Remove") });
+            alert.set_cancel_button (0);
+            alert.set_default_button (1);
+
+            alert.choose.begin (win, null, (obj, res) => {
+                try {
+                    int idx = alert.choose.end (res);
+                    if (idx == 1) {
+                        column.remove (box);
+
+                        // Select next available row
+                        var next_row = column.get_selected_row ();
+                        if (next_row == null) {
+                            next_row = column.get_row_at_index (0);
+                        }
 
-                    if (next_row != null) {
-                        column.select_row (next_row);
-                    } else {
-                        win.edit_view_content.buffer.text = "";
-                        win.edit_view_content.modified = false;
-                        store.clear ();
-                    }
+                        if (next_row != null) {
+                            column.select_row (next_row);
+                        } else {
+                            win.edit_view_content.buffer.text = "";
+                            win.edit_view_content.modified = false;
+                            store.clear ();
+                        }
 
-                    Services.FileManager.get_instance ().save_open_files (win);
+                        Services.FileManager.get_instance ().save_open_files (win);
+                    }
+                } catch (Error e) {
+                    warning ("Alert error: %s", e.message);
                 }
-                dialog.destroy ();
             });
-
-            dialog.show ();
         }
 
         // Legacy compatibility methods

src/Widgets/WebView.vala

@@ -209,13 +209,7 @@ namespace Quilter {
         }
 
         public async void update_html_view_async () {
-            try {
-                warning ("Starting update_html_view_async\n");
-                update_html_view ();
-                warning ("Finished update_html_view_async\n");
-            } catch (Error e) {
-                warning ("Error in update_html_view_async: %s\n", e.message);
-            }
+            update_html_view ();
             yield;
         }