allow parametrization of site details

Author: lameze

Diff for: .github/workflows/web-install.yml

@@ -16,6 +16,14 @@ jobs:
   behat:
     runs-on: ubuntu-latest
 
+    env:
+      MOODLE_SITE_URL: http://localhost:8080/moodle
+      DB_TYPE: pgsql
+      DB_HOST: localhost
+      DB_NAME: test
+      DB_USER: test
+      DB_PASS: test
+
     steps:
       - name: Setting up DB PostgreSQL
         uses: m4nu56/postgresql-action@v1

Diff for: tests/behat/Context/FeatureContext.php

@@ -4,6 +4,41 @@
 use Behat\MinkExtension\Context\MinkContext;
 use Behat\Behat\Context\Context;
 
+/**
+ * Defines application features from the specific context.
+ */
 class FeatureContext extends MinkContext implements Context {
 
+    /**
+     * @Given I am on the moodle site to be installed
+     */
+    public function iAmOnTheMoodleSiteToBeInstalled() {
+        $baseurl = getenv('MOODLE_SITE_URL') ?: 'http://localhost';
+
+        $this->visitPath("{$baseurl}");
+    }
+
+    /**
+     * @When I fill in the database type
+     */
+    public function iFillInTheDatabaseType() {
+        $dbtype = getenv('DB_TYPE') ?: 'pgsql';
+
+        $this->fillField('dbtype', $dbtype);
+    }
+
+    /**
+     * @When I fill in the database settings
+     */
+    public function iFillInTheDatabaseSettings() {
+        $dbhost = getenv('DB_HOST') ?: 'localhost';
+        $dbname = getenv('DB_NAME') ?: 'moodle';
+        $dbuser = getenv('DB_USER') ?: 'postgres';
+        $dbpass = getenv('DB_PASS') ?: 'moodle';
+
+        $this->fillField('dbhost', $dbhost);
+        $this->fillField('dbname', $dbname);
+        $this->fillField('dbuser', $dbuser);
+        $this->fillField('dbpass', $dbpass);
+    }
 }

Diff for: tests/behat/install.feature

@@ -1,7 +1,7 @@
 Feature: Moodle Web Installation
 
   Scenario: Verify successful installation of Moodle
-    Given I am on "http://localhost:8080/moodle"
+    Given I am on the moodle site to be installed
 
     # First page: Choose a language
     And I should see "Installation"
@@ -14,21 +14,20 @@ Feature: Moodle Web Installation
     And I press "Next"
 
     # Choose database driver
-    And I fill in "dbtype" with "pgsql"
+    And I fill in the database type
     And I press "Next"
 
     # Database settings
-    When I fill in "dbhost" with "localhost"
-    When I fill in "dbname" with "test"
-    When I fill in "dbuser" with "test"
-    When I fill in "dbpass" with "test"
+    And I fill in the database settings
     And I press "Next"
 
-    # Configuration completed: --> We only see this part if Moodle could not save the config.php
+    # Configuration completed: --> Only needed if Moodle could not save the config.php
     # And I should see "Configuration completed"
     # And I press "Next"
 
     # Installation
+    And I should see "Installation"
+    And I should see "Modular Object-Oriented Dynamic Learning Environment"
     And I should see "Have you read these conditions and understood them?"
     And I press "Continue"
 
@@ -50,7 +49,7 @@ Feature: Moodle Web Installation
     And I fill in "s__shortname" with "sitetest"
     And I fill in "s__supportemail" with "[email protected]"
     And I fill in "s__noreplyaddress" with "[email protected]"
-    And I press "Save changes"
+    When I press "Save changes"
 
     # Installation finished.
-    And I should see "Welcome, admin!"
+    Then I should see "Welcome, admin!"