qa: remove deprecated configuration support

Signed-off-by: Maximilian Bösing <[email protected]>

Author: boesing

psalm-baseline.xml

@@ -1,14 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <files psalm-version="5.22.2@d768d914152dbbf3486c36398802f74e80cfde48">
-  <file src="src/Command/DeprecatedStorageFactoryConfigurationCheckCommand.php">
-    <MixedArgument>
-      <code><![CDATA[$cacheConfiguration]]></code>
-      <code><![CDATA[$configuration]]></code>
-    </MixedArgument>
-    <MixedPropertyTypeCoercion>
-      <code><![CDATA[$projectConfiguration]]></code>
-    </MixedPropertyTypeCoercion>
-  </file>
   <file src="src/Exception/BadMethodCallException.php">
     <UnusedClass>
       <code><![CDATA[BadMethodCallException]]></code>
@@ -352,15 +343,6 @@
       <code><![CDATA[TotalSpaceCapableInterface]]></code>
     </UnusedClass>
   </file>
-  <file src="test/Command/DeprecatedStorageFactoryConfigurationCheckCommandTest.php">
-    <DeprecatedMethod>
-      <code><![CDATA[withConsecutive]]></code>
-      <code><![CDATA[withConsecutive]]></code>
-      <code><![CDATA[withConsecutive]]></code>
-      <code><![CDATA[withConsecutive]]></code>
-      <code><![CDATA[withConsecutive]]></code>
-    </DeprecatedMethod>
-  </file>
   <file src="test/Pattern/AbstractCommonPatternTest.php">
     <PossiblyUnusedMethod>
       <code><![CDATA[getCommonPatternNamesProvider]]></code>
@@ -483,12 +465,6 @@
       <code><![CDATA[array]]></code>
     </MixedInferredReturnType>
   </file>
-  <file src="test/Service/DeprecatedSchemaDetectorTest.php">
-    <MixedInferredReturnType>
-      <code><![CDATA[Generator]]></code>
-      <code><![CDATA[Generator]]></code>
-    </MixedInferredReturnType>
-  </file>
   <file src="test/Service/StorageAdapterFactoryFactoryTest.php">
     <DeprecatedMethod>
       <code><![CDATA[withConsecutive]]></code>

src/Command/DeprecatedStorageFactoryConfigurationCheckCommand.php

@@ -2,23 +2,18 @@
 
 namespace Laminas\Cache;
 
-use Laminas\Cache\Command\DeprecatedStorageFactoryConfigurationCheckCommand;
-use Laminas\Cache\Command\DeprecatedStorageFactoryConfigurationCheckCommandFactory;
 use Laminas\Cache\Service\StorageAdapterFactory;
 use Laminas\Cache\Service\StorageAdapterFactoryFactory;
 use Laminas\Cache\Service\StorageAdapterFactoryInterface;
 use Laminas\Cache\Service\StoragePluginFactory;
 use Laminas\Cache\Service\StoragePluginFactoryFactory;
 use Laminas\Cache\Service\StoragePluginFactoryInterface;
 use Laminas\ServiceManager\ServiceManager;
-use Symfony\Component\Console\Command\Command;
-
-use function class_exists;
 
 /**
  * @psalm-import-type ServiceManagerConfiguration from ServiceManager
  */
-class ConfigProvider
+final class ConfigProvider
 {
     public const ADAPTER_PLUGIN_MANAGER_CONFIGURATION_KEY = 'storage_adapters';
 
@@ -31,7 +26,6 @@ public function __invoke(): array
     {
         return [
             'dependencies' => $this->getDependencyConfig(),
-            'laminas-cli'  => $this->getCliConfig(),
         ];
     }
 
@@ -42,7 +36,7 @@ public function __invoke(): array
      */
     public function getDependencyConfig(): array
     {
-        $dependencies = [
+        return [
             'abstract_factories' => [
                 Service\StorageCacheAbstractServiceFactory::class,
             ],
@@ -55,31 +49,5 @@ public function getDependencyConfig(): array
                 StorageAdapterFactoryInterface::class => StorageAdapterFactoryFactory::class,
             ],
         ];
-
-        if (class_exists(Command::class)) {
-            $dependencies['factories'] += [
-                DeprecatedStorageFactoryConfigurationCheckCommand::class
-                    => DeprecatedStorageFactoryConfigurationCheckCommandFactory::class,
-            ];
-        }
-
-        return $dependencies;
-    }
-
-    /**
-     * @return array<string,mixed>
-     */
-    public function getCliConfig(): array
-    {
-        if (! class_exists(Command::class)) {
-            return [];
-        }
-
-        return [
-            'commands' => [
-                DeprecatedStorageFactoryConfigurationCheckCommand::NAME
-                    => DeprecatedStorageFactoryConfigurationCheckCommand::class,
-            ],
-        ];
     }
 }

src/Command/DeprecatedStorageFactoryConfigurationCheckCommandFactory.php

@@ -2,7 +2,7 @@
 
 namespace Laminas\Cache;
 
-class Module
+final class Module
 {
     /**
      * Return default laminas-cache configuration for laminas-mvc context.
@@ -12,7 +12,6 @@ public function getConfig(): array
         $provider = new ConfigProvider();
         return [
             'service_manager' => $provider->getDependencyConfig(),
-            'laminas-cli'     => $provider->getCliConfig(),
         ];
     }
 }