Nullable flag on constructor property promotion, closes #183

Signed-off-by: Grundik <[email protected]>

Author: Grundik

src/Generator/ParameterGenerator.php

@@ -167,6 +167,14 @@ public function getType()
             : null;
     }
 
+    /**
+     * @return bool
+     */
+    public function getNullable()
+    {
+        return $this->type && $this->type->getNullable();
+    }
+
     /**
      * @param  string $name
      * @return ParameterGenerator

src/Generator/PromotedParameterGenerator.php

@@ -87,6 +87,10 @@ public static function fromParameterGeneratorWithVisibility(ParameterGenerator $
             );
         }
 
+        if ($type && $generator->getNullable()) {
+            $type = '?' . $type;
+        }
+
         return new self(
             $name,
             $type,

src/Generator/TypeGenerator.php

@@ -140,6 +140,14 @@ public function __toString(): string
         return $this->type->toString();
     }
 
+    /**
+     * @return bool Nullable flag
+     */
+    public function getNullable()
+    {
+        return $this->nullable;
+    }
+
     /**
      * @return bool[]|string[] ordered tuple, first key represents whether the type is nullable, second is the
      *                         trimmed string

test/Generator/PromotedParameterGeneratorTest.php

@@ -0,0 +1,25 @@
+<?php
+
+declare(strict_types=1);
+
+namespace LaminasTest\Code\Generator;
+
+use Laminas\Code\Generator\PromotedParameterGenerator;
+use Laminas\Code\Reflection\ParameterReflection;
+use LaminasTest\Code\TestAsset\ClassWithPromotedProperties;
+use PHPUnit\Framework\Attributes\Group;
+use PHPUnit\Framework\TestCase;
+
+#[Group('Laminas_Code_Generator')]
+#[Group('Laminas_Code_Generator_Php')]
+class PromotedParameterGeneratorTest extends TestCase
+{
+    public function testNullablePromotedProperty(): void
+    {
+        $parameterReflection = new ParameterReflection([ClassWithPromotedProperties::class, '__construct'], 0);
+
+        $generator = PromotedParameterGenerator::fromReflection($parameterReflection);
+
+        $this->assertSame('protected ?int $nullable', $generator->generate());
+    }
+}

test/TestAsset/ClassWithPromotedProperties.php

@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace LaminasTest\Code\TestAsset;
+
+/**
+ * Class with a promoted constructor properties
+ *
+ * @license MIT
+ */
+class ClassWithPromotedProperties
+{
+    public function __construct(
+        protected ?int $nullable
+    ) {
+    }
+}