PHP 8.1 `new` in initializers support

[Ocramius]

https://wiki.php.net/rfc/new_in_initializers

[michaelpetri]

This one should be implemented as a new flag as well? PropertyGenerator::FLAG_IN_INITIALIZER ?

[Ocramius]

Difficult to say: I think this is part of ParameterGenerator, not PropertyGenerator? 🤔

The bulk of all logic lives in the ValueGenerator, which is not currently capable of complex expressions:

laminas-code/src/Generator/ValueGenerator.php

Line 27 in e9e2dcc

class ValueGenerator extends AbstractGenerator

It may perhaps be something relevant post-release, but the isomorphism between ParameterGenerator and ReflectionParameter is something we should try to achieve

[michaelpetri]

Will give it a try on wednesday @lyska or after my other two open patches ✌️

[Ocramius]

As discussed with @michaelpetri, the problem with new in initializers is that we can't deduct a PHP expression for generating a value, when given a value.

The ValueGenerator would need radical adjustments here, but it would not be capable of generating an expression in a reliable way.

For example:

class MyDefaultValue {
    public int $value;
    public function __construct() {
        $this->value = random_int(1, 10000);
    }
}

$value = new MyDefaultGenerator();

// this is potentially wrong: `'new MyDefaultValue()'` is probably not reliable either?
$parameterGenerator->setDefaultValue(ValueGenerator::fromObject($value)); 

I don't think it is realistically feasible to solve this problem by 4.5.0, and therefore removing the milestone.

[nicolas-grekas]

This might be doable by casting reflectors to string since php/php-src#7540