RBAC addRole: The role missing children, if the roles are added in wrong order

[kenchou]

Bug Report

Q	A
Version(s)	3.1.0

Summary

The role permissions are wrong, if the roles are added in a different order

I use the package mezzio/mezzio-authorization-rbac.
some basic role in global.php, and add some debug role in local.php.
After merging, The local configuration is always after the global configuration

P:

1. Role A is role B's parent, B is A's child
2. add role with role name (string)

if add A before B, role A has child B, It's OK.
But if add A after B, role A hash no children!

Current behavior

How to reproduce

return [
    // ...
    'mezzio-authorization-rbac' => [
        'roles' => [
            '__member__' => ['SystemAdministrator'],
            '__guest__' => ['__member__'],
            'SystemAdministrator' => [],
        ],
        'permissions' => [
            '__guest__' => [
                'home',
                'account.login',
                'account.logout',
            ],
            '__member__' => [
                'account.profile',
            ],
        ],
    ]
];

if the role 'SystemAdministrator' is after member， it has no children.
if the role 'SystemAdministrator' is before member, the result is OK.

Expected behavior

SystemAdministrator has child member, ignore the order of addition.

[froschdesign]

@kenchou
This component does not use are merge anything from configuration files. The configuration is used in a factory of mezzio-authorization-rbac: Mezzio\Authorization\Rbac\LaminasRbacFactory:

https://github.com/mezzio/mezzio-authorization-rbac/blob/979a7e821033fa819730998448491b7b1cd0833e/src/LaminasRbacFactory.php#L43-L45

Please report this problem in the issue tracker of mezzio-authorization-rbac. Thanks!

[kenchou]

mezzio configuration file merge order is OK. global first, local (for dev) overwrite or append it.

The root cause of the problem is addRole from string.
It new instance Even if role already exists (create with createMissingRoles=true)

    public function addRole($role, $parents = null) : void
    {
        if (is_string($role)) {
            $role = new Role($role);
        }

should first try to get an existing instance

$role = $this->roles[$role] ?? new Role($role);

[froschdesign]

@kenchou
Please create a unit test which demonstrates the problem and send it as pull request to this repository. Thanks in advance! 👍

[kenchou]

I create a unit test and open a PR：
#24

thx.