Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit d19dbd1

Browse files
committedJun 14, 2020
fix invalid param, remove unused parameter
1 parent b49658a commit d19dbd1

File tree

3 files changed

+5
-31
lines changed

3 files changed

+5
-31
lines changed
 

‎phpstan-baseline.neon

-26
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,2 @@
11
parameters:
22
ignoreErrors:
3-
-
4-
message: "#^PHPDoc tag @param has invalid value \\(\\$name\\)\\: Unexpected token \"\\$name\", expected type at offset 133$#"
5-
count: 1
6-
path: src/AbstractFactoryInterface.php
7-
8-
-
9-
message: "#^PHPDoc tag @param has invalid value \\(\\$requestedName\\)\\: Unexpected token \"\\$requestedName\", expected type at offset 153$#"
10-
count: 1
11-
path: src/AbstractFactoryInterface.php
12-
13-
-
14-
message: "#^PHPDoc tag @param has invalid value \\(\\$name\\)\\: Unexpected token \"\\$name\", expected type at offset 111$#"
15-
count: 1
16-
path: src/AbstractFactoryInterface.php
17-
18-
-
19-
message: "#^PHPDoc tag @param has invalid value \\(\\$requestedName\\)\\: Unexpected token \"\\$requestedName\", expected type at offset 131$#"
20-
count: 1
21-
path: src/AbstractFactoryInterface.php
22-
23-
-
24-
message: "#^Closure invoked with 4 parameters, 0 required\\.$#"
25-
count: 1
26-
path: src/ServiceManager.php
27-
28-

‎src/AbstractFactoryInterface.php

+4-4
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ interface AbstractFactoryInterface extends Factory\AbstractFactoryInterface
4141
* Determine if we can create a service with name
4242
*
4343
* @param ServiceLocatorInterface $serviceLocator
44-
* @param $name
45-
* @param $requestedName
44+
* @param string $name
45+
* @param string $requestedName
4646
* @return bool
4747
*/
4848
public function canCreateServiceWithName(ServiceLocatorInterface $serviceLocator, $name, $requestedName);
@@ -51,8 +51,8 @@ public function canCreateServiceWithName(ServiceLocatorInterface $serviceLocator
5151
* Create service with name
5252
*
5353
* @param ServiceLocatorInterface $serviceLocator
54-
* @param $name
55-
* @param $requestedName
54+
* @param string $name
55+
* @param string $requestedName
5656
* @return mixed
5757
*/
5858
public function createServiceWithName(ServiceLocatorInterface $serviceLocator, $name, $requestedName);

‎src/ServiceManager.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -646,7 +646,7 @@ private function createDelegatorFromName($name, array $options = null)
646646
};
647647
}
648648

649-
return $creationCallback($this->creationContext, $name, $creationCallback, $options);
649+
return $creationCallback();
650650
}
651651

652652
/**

0 commit comments

Comments
 (0)
Please sign in to comment.