Skip to content

Commit f8eb5b9

Browse files
committed
Changes from code review
Signed-off-by: Gary Hockin <[email protected]>
1 parent 1d428e6 commit f8eb5b9

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/ServiceManager.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -748,7 +748,7 @@ private function createLazyServiceDelegatorFactory()
748748
private function mergeDelegators(array $config)
749749
{
750750
foreach ($config as $key => $delegators) {
751-
if (! isset($this->delegators[$key])) {
751+
if (! array_key_exists($key, $this->delegators)) {
752752
$this->delegators[$key] = $delegators;
753753
continue;
754754
}

test/ServiceManagerTest.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -367,10 +367,10 @@ public function testResolvedAliasNoMatchingAbstractFactoryReturnsFalse()
367367
}
368368

369369
/**
370-
* Hotfix #3
370+
* @group #3
371371
* @see https://github.com/laminas/laminas-servicemanager/issues/3
372372
*/
373-
public function testConfigureMultipleTimesAvoidsDuplicates()
373+
public function testConfiguringADelegatorMultipleTimesDoesNotLeadToDuplicateDelegatorCalls()
374374
{
375375
$delegatorFactory = function (
376376
ContainerInterface $container,

0 commit comments

Comments
 (0)