💚 Fix

Author: falexwolf

nbproject/dev/_jupyter_communicate.py

@@ -121,6 +121,9 @@ def find_nb_path_via_parent_process():
             if arg.endswith(".ipynb"):
                 potential_path = arg  # Store the last one found
 
+        if is_nbconvert_call and "--inplace" not in cmdline:
+            raise ValueError("Please execute 'nbconvert' with option '--inplace'.")
+
         if is_nbconvert_call and potential_path:
             # We found something that looks like an nbconvert call and an ipynb file
             # The path might be relative to the parent process's CWD.
@@ -169,6 +172,8 @@ def find_nb_path_via_parent_process():
     except psutil.Error as e:
         logger.warning(f"psutil error: {e}")
         return None
+    except ValueError as ve:  # Explicitly catch and re-raise the intended error
+        raise ve
     except Exception as e:
         logger.warning(f"Unexpected error during psutil check: {e}")
         return None

tests/test_nbconvert.py

@@ -10,4 +10,16 @@ def test_running_via_nbconvert():
     )
     print(result.stdout.decode())
     print(result.stderr.decode())
-    assert result.returncode == 0
+    assert result.returncode == 1
+    assert (
+        "Please execute 'nbconvert' with option '--inplace'." in result.stderr.decode()
+    )
+
+    result = subprocess.run(
+        "jupyter nbconvert --to notebook --inplace --execute ./tests/for-nbconvert.ipynb",
+        shell=True,
+        capture_output=True,
+    )
+    print(result.stdout.decode())
+    print(result.stderr.decode())
+    assert result.returncode == 1