🚸 Error for nbconvert if --inplace is not passed (#289)

* ✅ Error for nbconvert if --inplace is not passed

* Revert "✅ Error for nbconvert if --inplace is not passed"

This reverts commit 105d18a.

* 💚 Fix

* 💚 Fix

* 👷 Run CI on Python 3.13

Author: falexwolf

.github/workflows/build.yml

@@ -12,7 +12,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.10", "3.11"]
+        python-version: ["3.10", "3.13"]
 
     steps:
       - name: Checkout main
@@ -61,7 +61,7 @@ jobs:
       - run: nox -s build
 
       - name: Codecov
-        if: matrix.python-version == '3.11'
+        if: matrix.python-version == '3.13'
         uses: codecov/codecov-action@v2
         with:
           token: ${{ secrets.CODECOV_TOKEN }}

nbproject/dev/_jupyter_communicate.py

@@ -121,6 +121,11 @@ def find_nb_path_via_parent_process():
             if arg.endswith(".ipynb"):
                 potential_path = arg  # Store the last one found
 
+        if is_nbconvert_call and "--inplace" not in cmdline:
+            raise ValueError(
+                "Please execute notebook 'nbconvert' by passing option '--inplace'."
+            )
+
         if is_nbconvert_call and potential_path:
             # We found something that looks like an nbconvert call and an ipynb file
             # The path might be relative to the parent process's CWD.
@@ -169,6 +174,8 @@ def find_nb_path_via_parent_process():
     except psutil.Error as e:
         logger.warning(f"psutil error: {e}")
         return None
+    except ValueError as ve:  # Explicitly catch and re-raise the intended error
+        raise ve
     except Exception as e:
         logger.warning(f"Unexpected error during psutil check: {e}")
         return None

tests/test_nbconvert.py

@@ -8,6 +8,17 @@ def test_running_via_nbconvert():
         shell=True,
         capture_output=True,
     )
+    assert result.returncode == 1
+    assert (
+        "Please execute notebook 'nbconvert' by passing option '--inplace'."
+        in result.stderr.decode()
+    )
+
+    result = subprocess.run(
+        "jupyter nbconvert --to notebook --inplace --execute ./tests/for-nbconvert.ipynb",
+        shell=True,
+        capture_output=True,
+    )
     print(result.stdout.decode())
     print(result.stderr.decode())
     assert result.returncode == 0