Skip to content

Python package depends implicitly on pylance #309

Description

@wjones127

We don't have any explicit dependency on pylance:

But we will import it here:

NATIVE_IMPLS: Dict[str, str] = {
"rest": "lance.namespace.RestNamespace",
"dir": "lance.namespace.DirectoryNamespace",
}

impl_class = NATIVE_IMPLS.get(impl) or _REGISTERED_IMPLS.get(impl) or impl
try:
module_name, class_name = impl_class.rsplit(".", 1)
module = importlib.import_module(module_name)

For now, we should list pylance as a dependency.

But separately, I think we should consider if we can make pylance not a required dependency. That's a pretty heavy dependency to add, given it has the full datafusion query engine embedded.

lancedb/lancedb#3053

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions