feat: Add achievement icons

Author: landaire

src/task.rs

@@ -490,6 +490,7 @@ pub fn load_wows_files(wows_directory: PathBuf, locale: &str) -> Result<Backgrou
         ship_icons: icons,
         ribbon_icons,
         subribbon_icons,
+        achievement_icons: HashMap::new(),
         replays_dir: replays_dir.clone(),
         build_dir,
     };

src/ui/replay_parser/mod.rs

@@ -723,18 +723,18 @@ impl UiReport {
                                 return None;
                             };
 
-                            let achievement_name = metadata_provider
-                                .localized_name_from_id(&format!("IDS_ACHIEVEMENT_{}", achievement_data.ui_name()))?;
+                            let ui_name = achievement_data.ui_name().to_string();
+                            let achievement_name =
+                                metadata_provider.localized_name_from_id(&format!("IDS_ACHIEVEMENT_{ui_name}"))?;
 
-                            let achievement_description = metadata_provider.localized_name_from_id(&format!(
-                                "IDS_ACHIEVEMENT_DESCRIPTION_{}",
-                                achievement_data.ui_name()
-                            ))?;
+                            let achievement_description = metadata_provider
+                                .localized_name_from_id(&format!("IDS_ACHIEVEMENT_DESCRIPTION_{ui_name}"))?;
 
                             Some(Achievement {
                                 game_param,
                                 display_name: achievement_name,
                                 description: achievement_description,
+                                icon_key: ui_name,
                                 count: achievement_count as usize,
                             })
                         })
@@ -1620,14 +1620,27 @@ impl UiReport {
                             if !report.achievements.is_empty() {
                                 ui.strong("Achievements");
 
+                                let mut wows_data = self.wows_data.write();
                                 for achievement in &report.achievements {
-                                    let response = if achievement.count > 1 {
-                                        ui.label(format!("{} ({}x)", &achievement.display_name, achievement.count))
-                                    } else {
-                                        ui.label(&achievement.display_name)
-                                    };
-                                    response.on_hover_text(&achievement.description);
+                                    ui.horizontal(|ui| {
+                                        if let Some(icon) = wows_data.achievement_icon(&achievement.icon_key) {
+                                            let image = Image::new(ImageSource::Bytes {
+                                                uri: icon.path.clone().into(),
+                                                bytes: icon.data.clone().into(),
+                                            })
+                                            .fit_to_exact_size((32.0, 32.0).into());
+                                            ui.add(image).on_hover_text(&achievement.description);
+                                        }
+
+                                        let response = if achievement.count > 1 {
+                                            ui.label(format!("{} ({}x)", &achievement.display_name, achievement.count))
+                                        } else {
+                                            ui.label(&achievement.display_name)
+                                        };
+                                        response.on_hover_text(&achievement.description);
+                                    });
                                 }
+                                drop(wows_data);
                             }
 
                             // Display ribbons
@@ -3492,8 +3505,18 @@ impl ToolkitTabViewer<'_> {
             if !all_achievements.is_empty() {
                 ui.strong("Achievements");
 
+                let mut wows_data = self.tab_state.world_of_warships_data.as_ref().unwrap().write();
                 for achievement in all_achievements {
                     ui.horizontal(|ui| {
+                        if let Some(icon) = wows_data.achievement_icon(&achievement.icon_key) {
+                            let image = Image::new(ImageSource::Bytes {
+                                uri: icon.path.clone().into(),
+                                bytes: icon.data.clone().into(),
+                            })
+                            .fit_to_exact_size((32.0, 32.0).into());
+                            ui.add(image).on_hover_text(&achievement.description);
+                        }
+
                         let response = ui.label(achievement.display_name);
                         response.on_hover_text(&achievement.description);
 
@@ -3502,6 +3525,7 @@ impl ToolkitTabViewer<'_> {
                         });
                     });
                 }
+                drop(wows_data);
             }
 
             ui.separator();

src/ui/replay_parser/models.rs

@@ -209,6 +209,7 @@ pub struct Achievement {
     pub game_param: Arc<Param>,
     pub display_name: String,
     pub description: String,
+    pub icon_key: String,
     pub count: usize,
 }
 

src/wows_data.rs

@@ -49,6 +49,9 @@ pub struct WorldOfWarshipsData {
     /// Subribbon icons keyed by ribbon name (e.g., "ribbon_main_caliber")
     pub subribbon_icons: HashMap<String, Arc<GameAsset>>,
 
+    /// Achievement icons, lazy-loaded and cached. Keyed by achievement name (lowercase).
+    pub achievement_icons: HashMap<String, Arc<GameAsset>>,
+
     #[allow(dead_code)]
     pub full_version: Option<wowsunpack::data::Version>,
     pub patch_version: usize,
@@ -59,6 +62,27 @@ pub struct WorldOfWarshipsData {
     pub build_dir: PathBuf,
 }
 
+impl WorldOfWarshipsData {
+    /// Get an achievement icon by name, lazy-loading and caching it from the game files.
+    /// The icon_key should be the lowercase achievement name (e.g., "pve_honorsstar").
+    pub fn achievement_icon(&mut self, icon_key: &str) -> Option<Arc<GameAsset>> {
+        if let Some(icon) = self.achievement_icons.get(icon_key) {
+            return Some(icon.clone());
+        }
+
+        let path = format!("gui/achievements/icon_achievement_{icon_key}.png");
+        let icon_node = self.file_tree.find(&path).ok()?;
+        let file_info = icon_node.file_info()?;
+
+        let mut icon_data = Vec::with_capacity(file_info.unpacked_size as usize);
+        icon_node.read_file(&self.pkg_loader, &mut icon_data).ok()?;
+
+        let asset = Arc::new(GameAsset { path, data: icon_data });
+        self.achievement_icons.insert(icon_key.to_string(), asset.clone());
+        Some(asset)
+    }
+}
+
 /// Shared dependencies needed for loading and parsing replays.
 /// This bundles together all the Arc-wrapped state that replay loading requires.
 #[derive(Clone)]