fix: patch Bitnami nginx-env.sh to use www-data worker user

Bitnami's nginx-env.sh hardcodes NGINX_DAEMON_USER='daemon', overwriting
any env var Lando sets. The entrypoint then rewrites the 'user' directive
in nginx.conf with this value. The only reliable fix is patching
nginx-env.sh before the entrypoint runs.

Added sed commands to launch.sh to replace 'daemon' with 'www-data'
in nginx-env.sh before the Bitnami entrypoint sources it.

Fixes: https://github.com/lando/drupal/issues/124

Author: AaronFeledy

config/launch.sh

@@ -47,6 +47,15 @@ fi
 lando_info "Rendered template /tmp/vhosts.lando to /opt/bitnami/nginx/conf/vhosts/lando.conf"
 lando_debug $(cat /opt/bitnami/nginx/conf/vhosts/lando.conf)
 
+# Set nginx worker user to www-data so it can serve files created by PHP
+# Bitnami's nginx-env.sh hardcodes NGINX_DAEMON_USER=daemon which overwrites
+# any env var we set, so we patch it before the entrypoint runs
+# See: https://github.com/lando/drupal/issues/124
+if [ -f "/opt/bitnami/scripts/nginx-env.sh" ]; then
+  sed -i 's/export NGINX_DAEMON_USER="daemon"/export NGINX_DAEMON_USER="www-data"/' /opt/bitnami/scripts/nginx-env.sh
+  sed -i 's/export NGINX_DAEMON_GROUP="daemon"/export NGINX_DAEMON_GROUP="www-data"/' /opt/bitnami/scripts/nginx-env.sh
+fi
+
 # Detect and run the correct entrypoint script. THANKS BITNAMI!
 if [ -f "/opt/bitnami/scripts/nginx/entrypoint.sh" ]; then
   /opt/bitnami/scripts/nginx/entrypoint.sh /opt/bitnami/scripts/nginx/run.sh

config/nginx.conf

@@ -1,5 +1,5 @@
 # Based on https://www.nginx.com/resources/wiki/start/topics/examples/full/#nginx-conf
-user              www-data www-data;  ## Default: nobody
+user              root root;  ## Default: nobody
 
 worker_processes  auto;
 error_log         "/opt/bitnami/nginx/logs/error.log";