Skip to content

fix(monitoring): handle SQLite token statistics errors - #2473

Closed
mameikagou wants to merge 1 commit into
langbot-app:masterfrom
mameikagou:fix-token-monitoring-2468
Closed

fix(monitoring): handle SQLite token statistics errors#2473
mameikagou wants to merge 1 commit into
langbot-app:masterfrom
mameikagou:fix-token-monitoring-2468

Conversation

@mameikagou

Copy link
Copy Markdown

Overview

Fixes #2468.

  • allow the existing SQLite monitoring bucket query to use the safe strftime function;
  • display the backend msg from plain API error objects instead of [object Object];
  • add focused backend and frontend regressions.

Screenshots

No layout change. Error text changes from:

[object Object]

to the backend-provided message.

Validation

  • uv run pytest tests/unit_tests/persistence/test_tenant_uow.py -q --tb=short --capture=no — 117 passed
  • uv run ruff check and uv run ruff format --check on changed Python files
  • node --test tests/unit/*.test.mjs — 35 passed
  • pnpm exec tsc --noEmit
  • pnpm lint — 0 errors
  • pnpm build
  • git diff --check

Checklist

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! ❤️ Before we can merge this pull request, we need you to sign the LangBot Contributor License Agreement (CLA). You keep full copyright of your code — the CLA grants us a license to use and distribute your contribution. Signing takes 10 seconds and covers all repositories in this organization, permanently.

感谢您的贡献!合并前请阅读并签署贡献者许可协议(CLA)。您保留代码的全部版权,签署仅需回复下方指定内容,一次签署对本组织全部仓库永久有效。


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@dosubot dosubot Bot added the javascript Pull requests that update Javascript code label Aug 25, 2026
@RockChinQ

Copy link
Copy Markdown
Member

Hi @mameikagou , please sign the CLA before we can merge this PR.

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@dadachann

Copy link
Copy Markdown
Collaborator

Thanks for the focused diagnosis and proposed fix. We independently reimplemented and merged the repair in #2479 because this PR could not pass the CLA gate. Closing this as superseded.

@dadachann dadachann closed this Aug 28, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

javascript Pull requests that update Javascript code size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: 仪表盘监控token数据失败返回[object Object]

3 participants