Making it easier to contribute to LangChain #35700
Replies: 11 comments 6 replies
-
|
No comments ? |
Beta Was this translation helpful? Give feedback.
-
|
From my point of view, this is a sensible change because it prevents contributors from doing a lot of work on PRs that were never aligned with maintainer priorities. The only friction I would watch is the gap between opening an issue and knowing whether it is actually ready for outside work. A lightweight label or maintainer note like ready for external contribution would probably reduce the back and forth a lot for new contributors. The trusted contributor signal also seems useful. It gives repeat contributors a clearer path without weakening the review process for brand new proposals. |
Beta Was this translation helpful? Give feedback.
-
|
Makes sense for feature work, but curious how this plays out for docs fixes or small tweaks — doesn't want the overhead to kill those contributions. Probably already thought through it, but worth calling out since those PRs add up. |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
Mason Daugherty (@mdrxy) You should really consider a way of banning potential contributors that just endlessly open up PRs and issues. It's clear people are setting their agents to essentially DDOS maintaners with slop. Super fustrating the good trusting nature of open source is dying. |
Beta Was this translation helpful? Give feedback.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
-
|
Oh, interesting shift. I like the idea of aligning on scope earlier — we've had a couple of cases where contributors went deep on a PR only to realize it didn't fit with the overall direction. But question for y'all: how are you handling situations where multiple people want to tackle the same issue? Are you assigning based on first-come, first-serve, or considering other factors like past contributions? On the automation side, the bot auto-closing PRs without a linked issue is smart, but it makes me wonder how you're handling edge cases. For example, contributions where the issue itself is vague or broad. Are you expecting contributors to refine the scope in their comments before approval? We've used something like this in our internal repos and had to tweak things like requiring a short ### Approach
1. Add a new parameter to `llm_chain()` for specifying X.
2. Update relevant docs with examples for Y.
3. Write tests for edge case Z and W.This helped us get better signal on whether the contributor "gets" the problem or if the maintainer needs to jump in sooner. Also, curious about the trusted contributor piece — are you finding that it significantly reduces review cycles? We've toyed with the idea of an "auto-approve" label for repeat contributors but never fully committed because scaling it felt tricky. Would love to know how you're balancing trust with quality here. |
Beta Was this translation helpful? Give feedback.
-
|
So we actually dealt with this kind of process bottleneck in one of our repos last year — same problem: lots of drive-by PRs without enough context, and it slowed down maintainers big time. What worked for us was adding a similar "issue-first" policy, but we automated some of the back-and-forth a bit more. We used a combo of One thing we also did was provide a basic template for "brief plans" in our contributing guide. Something like this: ### Plan
- Add/modify `function_name` in `file_name.py` to handle X
- Update `test_file.py` to add cases for A, B, and C
- Update docs at [link] if neededIt made it way easier to align on scope because contributors knew what kind of detail we wanted up front. People started self-filtering ideas that were too vague or massive. Curious: are you doing anything to actively nudge users toward smaller, more focused issues? We found that sometimes contributors would open these huge "mega issues" trying to cover everything, which made it harder to assign and track progress. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the update! The issue-first workflow makes sense. Looking forward to contributing. |
Beta Was this translation helpful? Give feedback.
-
|
Went through the new flow for the first time this week (#32197 → #38059), and one thing I couldn't work out: is opening the PR before assignment intended usage, or discouraged? The auto-close message says the PR "will be reopened automatically" once assigned — which reads as "open it now, it'll wake up later". But on issues like #32197 that's produced ~7 parallel approach comments, each with their own pre-opened (now auto-closed) PR, all waiting on the same assignment decision. Everyone has already invested the implementation effort the issue-first policy was meant to defer. If pre-opening is fine, a small queue signal on the issue (even the bot acking "N plans awaiting maintainer review") would help people decide whether to pile on or pick a different issue. If it's discouraged, it might be worth the bot saying so explicitly. Happy to be told I'm holding it wrong :) |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
We shipped a few changes to how external contributions work. The goal is to save contributors time by aligning on scope before code gets written, and to help maintainers prioritize reviews more effectively.
Talk to us before you code
External PRs now need to reference an approved issue (
Fixes #123,Closes #123, orResolves #123in the PR description), and you need to be assigned to that issue. PRs that don't meet these requirements will be automatically closed — but don't worry, the bot will tell you exactly what's missing, and your PR will reopen automatically once everything checks out.The quick version:
Fixes #<number>in the description before any other contentWe especially encourage issue authors to contribute fixes — you're closest to the problem and most likely to understand the context. This process keeps everyone on the same page and avoids the frustration of putting work into a PR that we can't merge.
For the full rundown on contributing, check out our Contributing Guide.
We now recognize repeat contributors
If you've had 5 or more PRs merged, you'll automatically get a
trusted-contributorlabel on your PRs and issues. This helps maintainers spot familiar faces during triage. If you've been contributing for a while — thank you, and your PRs will reflect that now.FAQ
I'm assigned to an issue but the check still failed?
Make sure your PR description includes one of the auto-close keywords (
Fixes,Closes, orResolves) followed by the issue number. The check re-runs when you edit the description.This is a new process and we're iterating on it. If something feels off or you have suggestions, let us know in this thread.
Beta Was this translation helpful? Give feedback.
All reactions