fix: VariableTruncator._truncate_array under-reports truncated flag#37213
Open
functionkiller wants to merge 1 commit into
Open
fix: VariableTruncator._truncate_array under-reports truncated flag#37213functionkiller wants to merge 1 commit into
functionkiller wants to merge 1 commit into
Conversation
- Set truncated=True when size-limit break drops tail elements - Use OR accumulation instead of assignment to preserve truncation state fixes langgenius#37192
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two bugs in
VariableTruncator._truncate_arraythat caused thetruncatedflag to be under-reported:used_size > target_size, the loopbreaks without settingtruncated = True, so dropped tail elements are not reflected in the flag.truncated = part_result.truncatedoverwrites the flag on each iteration. If an earlier element was truncated but a later element fits, the flag is incorrectly reset toFalse.Both sibling methods (
truncate_variable_mappingand_truncate_object) correctly accumulate the flag with|=oror.Changes
truncated = Truebefore the size-limitbreaktruncated = part_result.truncatedtotruncated = truncated or part_result.truncatedTest plan
truncated=Truewhen tail elements are droppedtruncated=Falseunchangedtruncated=TrueunchangedFixes #37192