`subscription($type)` method on Billable can return canceled subscriptions

[ignaciocunado]

Cashier Stripe Version

16.0

Laravel Version

11.44

PHP Version

8.2

Database Driver & Version

MariaDB

Description

When a user has an old (and canceled) subscription of a particular type and a new one which is active, this method under ManagesSubscriptions will return the canceled subscription.

    /**
     * Get a subscription instance by $type.
     *
     * @param  string  $type
     * @return \Laravel\Cashier\Subscription|null
     */
    public function subscription(string $type = 'default'): ?Subscription
    {
        return $this->subscriptions->where('type', $type)->first();
    }

I'm not sure whether this is the intended behaviour, but it is inconvenient at least.

Steps To Reproduce

1. Subscribe to a product.
2. Cancel the subscription today.
3. Subscribe again to the same product.
4. Call $user->susbcription($type).
5. The old and canceled one is returned.

[crynobone]

To our knowledge, this is the expected behaviour and it wasn't changed from upgrading 15 to 16.

[hailwood]

@crynobone I wouldn't say it's the expected behaviour so much as it's just the current incorrect behaviour.

If I have a customer that had a subscription and cancelled it, then they return a while later and start a new subscription—then I'd expect queries for whether they're now subscribed should be returning true. This holds true for subscribed/subscribedToProduct/subscribedToPrice.

Would you accept making the default in 17.x skipping cancelled subscriptions?

[ignaciocunado]

I agree with @hailwood, it doesn't make much sense to me that the function should behave like this.

If would be more than happy to submit a quick PR if @crynobone agrees.

[HenrijsFF]

Was running into this same exact issue. The problem I see is in the ManagesSubscriptions.php@subscription() method.
Right now it's using ->first() when in fact it should just be ->last(), because you'd always want the latest subscription for the specific type, no?

[ignaciocunado]

@HenrijsFF yes