Active and Canceled both return true

[Ronan-Lenor]

Cashier Stripe Version

15.7.1

Laravel Version

11.46.1

PHP Version

8.4.1

Database Driver & Version

No response

Description

that's because when i cancel a test clock, stripe cancel everything. so yeah the subscription don't exists anymore on Stripe and a webhook update the status of the subscription to "canceled". Upto here everything is fine. EXCEPT none of the methods used in valid() do care of that status. not even the canceled() itself 😅

So please, add something that check the status in all the method called by the valid() method.

Steps To Reproduce

server : subscribe something.
stripe : advance a test_clock
stripe : cancel the test_clock
server : retrieve the subscription

[Ronan-Lenor]

also related : #1550

[github-actions]

Thank you for reporting this issue!

As Laravel is an open source project, we rely on the community to help us diagnose and fix issues as it is not possible to research and fix every issue reported to us via GitHub.

If possible, please make a pull request fixing the issue you have described, along with corresponding tests. All pull requests are promptly reviewed by the Laravel team.

Thank you!

[krishnamitra03]

Hi, I’d like to work on this issue if it’s still open.
I’ve read through the discussion and will start by checking the Stripe webhook logic.
Please let me know if anyone else is already working on it. Thanks!

[Ronan-Lenor]

Things to know about this problem.

When a test_clock is ongoing, Cashier don't sync the time. Cashier, which rely on now(), become desynchronized.

To affect the entire laravel project (all vendors) that rely on Carbon, the usage of Carbon::hasTestNow() & Carbon::setTestNow() become necessary. (don't forget the webhooks)

Cashier also rely on the ends_at attribute to guess the state of the subscription. (without looking at the stripe_status attribute).
aside of canceled() there's a method, closer to what we should expect from that last one, called ended()