Merge pull request #187 from laravel/add-forbidden-handling

Throw separate "Forbidden" (403) exceptions

Author: jbrooksuk

src/Exceptions/ForbiddenException.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace Laravel\Forge\Exceptions;
+
+use Exception;
+
+class ForbiddenException extends Exception
+{
+    //
+}

src/MakesHttpRequests.php

@@ -4,6 +4,7 @@
 
 use Exception;
 use Laravel\Forge\Exceptions\FailedActionException;
+use Laravel\Forge\Exceptions\ForbiddenException;
 use Laravel\Forge\Exceptions\NotFoundException;
 use Laravel\Forge\Exceptions\RateLimitExceededException;
 use Laravel\Forge\Exceptions\TimeoutException;
@@ -91,6 +92,7 @@ protected function request($verb, $uri, array $payload = [])
      *
      * @throws \Exception
      * @throws \Laravel\Forge\Exceptions\FailedActionException
+     * @throws \Laravel\Forge\Exceptions\ForbiddenException
      * @throws \Laravel\Forge\Exceptions\NotFoundException
      * @throws \Laravel\Forge\Exceptions\ValidationException
      * @throws \Laravel\Forge\Exceptions\RateLimitExceededException
@@ -101,6 +103,10 @@ protected function handleRequestError(ResponseInterface $response)
             throw new ValidationException(json_decode((string) $response->getBody(), true));
         }
 
+        if ($response->getStatusCode() === 403) {
+            throw new ForbiddenException((string) $response->getBody());
+        }
+
         if ($response->getStatusCode() == 404) {
             throw new NotFoundException;
         }

tests/ForgeSDKTest.php

@@ -5,6 +5,7 @@
 use GuzzleHttp\Client;
 use GuzzleHttp\Psr7\Response;
 use Laravel\Forge\Exceptions\FailedActionException;
+use Laravel\Forge\Exceptions\ForbiddenException;
 use Laravel\Forge\Exceptions\NotFoundException;
 use Laravel\Forge\Exceptions\RateLimitExceededException;
 use Laravel\Forge\Exceptions\TimeoutException;
@@ -76,6 +77,19 @@ public function test_handling_404_errors()
         $forge->recipes();
     }
 
+    public function test_handling_forbidden_requests(): void
+    {
+        $this->expectException(ForbiddenException::class);
+
+        $forge = new Forge('123', $http = Mockery::mock(Client::class));
+
+        $http->shouldReceive('request')->once()->with('GET', 'recipes', [])->andReturn(
+            new Response(403)
+        );
+
+        $forge->recipes();
+    }
+
     public function test_handling_failed_action_errors()
     {
         $forge = new Forge('123', $http = Mockery::mock(Client::class));