Skip php serializer when igbinary is enable

[675076143]

Laravel Version

11.x

PHP Version

8.1.3

Database Driver & Version

No response

Description

Illuminate/Cache/RedisStore use serialize when SERIALIZER_IGBINARY is enable.
This will result in two serializations, and it's unnecessary.
Worse still, we can’t benefit from igbinary, the data size is still the same as php serialize.
Why not just let PhpRedis do the serialize?

https://github.com/laravel/framework/blob/11.x/src/Illuminate/Cache/RedisStore.php#L423

// config/database.php
return [
    'connections' => [
      'redis' => [
         'cache-compress' => [
            'options' => [
                'serializer' => \Redis::SERIALIZER_IGBINARY
            ]
        ],
    ]
];
// config/cache.php
return [
      'redis-compress' => [
        'driver' => 'redis',
        'connection' => 'cache-compress',
    ],
]

There is two way to fix this problem

1. disable the serialize function, just return the value, let PhpRedis do the thing.
2. Don't pass SERIALIZER_IGBINARY to PhpRedis, just use igbinary_serialize when config is enable.

// src/Illuminate/Cache/RedisStore.php
protected $enableIgbinary = false;


public function __construct(Redis $redis, $prefix = '', $connection = 'default')
{
    if ($this->connection()->client()->getOption(\Redis::OPT_SERIALIZER) === \Redis::SERIALIZER_IGBINARY) {
        $this->enableIgbinary = true;
    }
}


/**
 * @param mixed $value
 * @return mixed
 */
protected function serialize($value)
{
    if (is_numeric($value) && !in_array($value, [INF, -INF]) && !is_nan($value)) {
        return $value;
    }
    if ($this->enableIgbinary) {
        return $value;
    }
    return serialize($value);
}

/**
 * Unserialize the value.
 *
 * @param mixed $value
 * @return mixed
 */
protected function unserialize($value)
{
    if (is_numeric($value)) {
        return $value;
    }
    if ($this->enableIgbinary) {
        return $value;
    }
    return unserialize($value);
}

Steps To Reproduce

$input = ['a','b'];
$key = 'SERIALIZER_IGBINARY';
$redisClient = Redis::connection('cache-compress')->client();
$redisClient->set($key, $input); // use igbinary only
Cache::store('redis-compress')->put($key, $input); // use php serialize and igbinary

[CicerBro]

Wondering if this was ever implemented. Seems wasteful if Laravel does its own serialization and then again with igbinary.