Repository navigation
Undocumented breaking change in minor release #60565
Unanswered
Luke-Shepp
asked this question in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
After a dependabot update from 13.2 to 13.12 to receive new security updates, our test suite began failing with no messages, just an exit code 2.
Investigation led to a method signature update in #59455, shipped as part of 13.3.
Laravel explicitly states that minor and patch releases “should never contain breaking changes.” Changing
make($items = [])tomake($items = [], ...$args)breaks existing subclasses that override the public method with the old signature. PHP validates inheritance strictly and throws a fatal error.The change was intended as a compatibility fix for collections with extended constructors, but it overlooked the inverse compatibility problem: existing
make()overrides.It should have been one of:
All reactions