Skip to content

Commit

Permalink
Fix Laravel installer on Windows WSL (#385)
Browse files Browse the repository at this point in the history
* Fix test name

* Use rtrim instead of mb_trim
  • Loading branch information
JasonTame authored Jan 13, 2025
1 parent 4e355ef commit cae867c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/NewCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
$this->validateDatabaseOption($input);
$this->validateStackOption($input);

$name = mb_rtrim($input->getArgument('name'), '/\\');
$name = rtrim($input->getArgument('name'), '/\\');

$directory = $this->getInstallationDirectory($name);

Expand Down
2 changes: 1 addition & 1 deletion tests/NewCommandTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public function test_it_can_scaffold_a_new_laravel_app()
$this->assertFileExists($scaffoldDirectory.'/.env');
}

public function test_it_can_chops_trailing_slash_from_name()
public function test_it_can_chop_trailing_slash_from_name()
{
if ($this->runOnValetOrHerd('paths') === false) {
$this->markTestSkipped('Require `herd` or `valet` to resolve `APP_URL` using hostname instead of "localhost".');
Expand Down

0 comments on commit cae867c

Please sign in to comment.