remove fallbackPasskeyLabel

Author: benbjurstrom

src/PasskeyAuthenticatable.php

@@ -55,35 +55,25 @@ public function getPasskeyUserHandle(): string
      *
      * Shown prominently in authenticator UIs (registration prompts,
      * account pickers, password manager entries). Falls back from
-     * `name` to `email` to an opaque label derived from the user
-     * handle when those columns are absent.
+     * `name` to `email` to the auth identifier when columns are absent.
      */
     public function getPasskeyDisplayName(): string
     {
         return $this->getAttribute('name')
             ?? $this->getAttribute('email')
-            ?? $this->fallbackPasskeyLabel();
+            ?? (string) $this->getAuthIdentifier();
     }
 
     /**
      * Get the username for WebAuthn registration.
      *
      * Used as the account identifier in authenticator UIs, typically
      * rendered as the subtitle beneath the display name. Falls back
-     * to an opaque label derived from the user handle when `email`
-     * is absent.
+     * from `email` to the auth identifier when the column is absent.
      */
     public function getPasskeyUsername(): string
     {
         return $this->getAttribute('email')
-            ?? $this->fallbackPasskeyLabel();
-    }
-
-    /**
-     * An opaque, stable label used when no name or email is available.
-     */
-    protected function fallbackPasskeyLabel(): string
-    {
-        return 'user-'.substr(bin2hex($this->getPasskeyUserHandle()), 0, 10);
+            ?? (string) $this->getAuthIdentifier();
     }
 }

tests/Feature/PasskeyAuthenticatableTest.php

@@ -38,20 +38,16 @@
     expect($user->getPasskeyUsername())->toBe('only@example.com');
 });
 
-it('falls back to an opaque label when email is absent', function (): void {
-    config(['passkeys.user_handle_secret' => 'test-secret']);
-
+it('falls back to the auth identifier when email is absent', function (): void {
     Schema::create('bare_users', function (Blueprint $table): void {
         $table->id();
         $table->timestamps();
     });
 
     $user = BareUser::create();
-    $expected = 'user-'.substr(bin2hex($user->getPasskeyUserHandle()), 0, 10);
 
-    expect($user->getPasskeyDisplayName())->toBe($expected);
-    expect($user->getPasskeyUsername())->toBe($expected);
-    expect($expected)->not->toContain((string) $user->id);
+    expect($user->getPasskeyDisplayName())->toBe((string) $user->id);
+    expect($user->getPasskeyUsername())->toBe((string) $user->id);
 });
 
 it('returns the same handle across fresh model instances', function (): void {