Skip to content

Commit 6d2f48e

Browse files
authored
Replace -mmacosx-version-min with MACOSX_DEPLOYMENT_TARGET env var (#767)
1 parent 8da2cc4 commit 6d2f48e

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

.github/workflows/release.yml

+4-2
Original file line numberDiff line numberDiff line change
@@ -154,13 +154,14 @@ jobs:
154154
python -m pip install delocate wheel setuptools numpy six --no-cache-dir
155155
156156
./configure.py
157+
export MACOSX_DEPLOYMENT_TARGET=10.14
157158
158159
if [[ -n $GOOGLE_APPLICATION_CREDENTIALS ]]; then
159160
echo -e 'build --remote_http_cache=https://storage.googleapis.com/plumerai-bazel-cache/lce-release-macos-python${{ matrix.python-version }}' >> .bazelrc.user
160161
echo -e 'build --google_default_credentials' >> .bazelrc.user
161162
fi
162163
163-
bazelisk build :build_pip_pkg --copt=-fvisibility=hidden --copt=-mavx --copt=-mmacosx-version-min=10.14 --linkopt=-mmacosx-version-min=10.14 --linkopt=-dead_strip --distinct_host_configuration=false
164+
bazelisk build :build_pip_pkg --copt=-fvisibility=hidden --copt=-mavx --linkopt=-dead_strip --distinct_host_configuration=false
164165
bazel-bin/build_pip_pkg artifacts --plat-name macosx_10_14_x86_64
165166
166167
for f in artifacts/*.whl; do
@@ -196,13 +197,14 @@ jobs:
196197
python -m pip install delocate wheel setuptools numpy six --no-cache-dir
197198
198199
./configure.py
200+
export MACOSX_DEPLOYMENT_TARGET=11.0
199201
200202
if [[ -n $GOOGLE_APPLICATION_CREDENTIALS ]]; then
201203
echo -e 'build --remote_http_cache=https://storage.googleapis.com/plumerai-bazel-cache/lce-release-macos-arm-python${{ matrix.python-version }}' >> .bazelrc.user
202204
echo -e 'build --google_default_credentials' >> .bazelrc.user
203205
fi
204206
205-
bazelisk build :build_pip_pkg --copt=-fvisibility=hidden --copt=-mmacosx-version-min=11.0 --linkopt=-mmacosx-version-min=11.0 --linkopt=-dead_strip --config=macos_arm64
207+
bazelisk build :build_pip_pkg --copt=-fvisibility=hidden --linkopt=-dead_strip --config=macos_arm64
206208
bazel-bin/build_pip_pkg artifacts --plat-name macosx_11_0_arm64
207209
208210
for f in artifacts/*.whl; do

0 commit comments

Comments
 (0)