Skip to content

Error message reflection in /login?error=... #184

Description

@ryota-murakami

Summary

Raw rateLimitResult.error and oauthError.message are reflected into redirect URLs.

Source

P2 follow-up from /ship adversarial review of PR #176 (silent GitHub token refresh).

Details

route.ts:80,124 reflect rateLimitResult.error and oauthError.message via encodeURIComponent to a redirect URL.

Fix

Emit fixed error codes only (rate_limited, oauth_failed); keep messages in server logs / Sentry.

Acceptance

  • No raw error messages in /login?error=...
  • Stable error codes documented
  • Tests assert only canonical codes appear in URLs

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2-mediumPlan for this monthsecuritySecurity vulnerabilities and hardening

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions