Context
From /review on #59 — originally 5 design findings, all informational. One (Back-button tap area) was dropped after PR #173 abolished the 44px tap-target rule for this desktop app in favor of the WCAG 24px AA floor, so 4 findings remain.
Details
Several marketplace components use arbitrary font sizes below the 16px body-text minimum and bypass the OKLCH theme system:
text-[11px] on "Top 5" badge (MarketplaceDashboard.tsx:55)text-[11px] on URL bar (MarketplaceSkillPreview.tsx:109)text-[13px] on browse prompt (MarketplaceDashboard.tsx:59)text-amber-500 for bookmarked count bypasses OKLCH --theme-hue tinting (MarketplaceDashboard.tsx:50)
Notes
These match existing codebase conventions for secondary/badge text (e.g., text-[11px] is used elsewhere for installed badges). The text-amber-500 for bookmarks is consistent with the bookmark star color across the app. Consider whether to enforce strict compliance or document these as intentional exceptions.
Line numbers above are from when filed and may have shifted; all four findings were re-confirmed present as of 2026-05-27.
Context
From
/reviewon #59 — originally 5 design findings, all informational. One (Back-button tap area) was dropped after PR #173 abolished the 44px tap-target rule for this desktop app in favor of the WCAG 24px AA floor, so 4 findings remain.Details
Several marketplace components use arbitrary font sizes below the 16px body-text minimum and bypass the OKLCH theme system:
text-[11px]on "Top 5" badge (MarketplaceDashboard.tsx:55)text-[11px]on URL bar (MarketplaceSkillPreview.tsx:109)text-[13px]on browse prompt (MarketplaceDashboard.tsx:59)text-amber-500for bookmarked count bypasses OKLCH--theme-huetinting (MarketplaceDashboard.tsx:50)Notes
These match existing codebase conventions for secondary/badge text (e.g.,
text-[11px]is used elsewhere for installed badges). Thetext-amber-500for bookmarks is consistent with the bookmark star color across the app. Consider whether to enforce strict compliance or document these as intentional exceptions.