fix(taruchi): skip unrevealed detail records

Author: kanyaveral

packages/store-indexer/src/leaderboard/buildTaruchiDetails.test.ts

@@ -10,7 +10,6 @@ import {
   type TaruchiStatusRow,
 } from "./buildTaruchiDetails";
 
-const MASK_16 = 0xffffn;
 const i16 = (n: number): bigint => BigInt(n & 0xffff);
 const packStats = (health: number, power: number, harmony: number, violence: number): bigint =>
   i16(health) | (i16(power) << 16n) | (i16(harmony) << 32n) | (i16(violence) << 48n);
@@ -197,11 +196,6 @@ describe("buildTaruchiDetails", () => {
     expect(d.ascended).toBe(false);
   });
 
-  // Guard the int16 mask constant the helpers rely on.
-  it("uses a 16-bit mask", () => {
-    expect(MASK_16).toBe(0xffffn);
-  });
-
   it("splits eight-player festival results into the collapsed tier bucket", () => {
     const festivalCores = Array.from({ length: 8 }, (_, i) => ({
       id: BigInt(1000 + i),
@@ -237,4 +231,35 @@ describe("buildTaruchiDetails", () => {
       champion: { wins: 0, losses: 0 },
     });
   });
+
+  it("does not accumulate bracket records for unrevealed tarus", () => {
+    const unrevealedCore = { id: 400n, owner: "0xDDD", index: 4 };
+    const out = buildTaruchiDetails({
+      tourneys: [],
+      duels: [{ id: 123n, status: 2, bracket: 1, playerAIndex: 4, playerBIndex: 99 }],
+      results: [{ id: 123n, placements: packU32([4, 99]) }],
+      cores: [unrevealedCore],
+      statuses: [status({ id: 400n, state: 0 })],
+      names: [],
+      byTaruchi: new Map(),
+      spriteFor: (core) => `sprite/${core.index}`,
+      decodeName: (s) => s,
+    });
+
+    expect(out.get("400")!.record).toEqual({
+      wins: 0,
+      losses: 0,
+      tournaments: 0,
+      bestPlacement: 8,
+      winrate: 0,
+      qualified: false,
+      onyxWon: 0,
+      onyxSpent: 0,
+    });
+    expect(out.get("400")!.bracketRecord).toEqual({
+      rookie: { wins: 0, losses: 0 },
+      veteran: { wins: 0, losses: 0 },
+      champion: { wins: 0, losses: 0 },
+    });
+  });
 });

packages/store-indexer/src/leaderboard/buildTaruchiDetails.ts

@@ -119,6 +119,7 @@ export interface BuildTaruchiDetailsInput {
   decodeName: (name: string) => string;
 }
 
+const TARUCHI_STATE_UNREVEALED = 0;
 const TARUCHI_STATE_ASCENDED = 4;
 const NEVER_PLACED = 8;
 const MASK_16 = 0xffffn;
@@ -177,8 +178,14 @@ export function buildTaruchiDetails(input: BuildTaruchiDetailsInput): Map<string
   const { tourneys, duels, results, cores, statuses, names, byTaruchi, spriteFor, decodeName } = input;
 
   const statusById = new Map(statuses.map((s) => [String(s.id), s]));
+  const coreByIndex = new Map(cores.map((c) => [c.index, c]));
   const nameById = new Map(names.map((n) => [String(n.id), n.name]));
   const resultById = new Map(results.map((r) => [String(r.id), r.placements]));
+  const shouldAccumulateIndex = (idx: number): boolean => {
+    const core = coreByIndex.get(idx);
+    if (!core) return false;
+    return statusById.get(String(core.id))?.state !== TARUCHI_STATE_UNREVEALED;
+  };
 
   // Per-tier W/L, keyed by taruchi index, using the SAME placement → won/lost
   // math as buildAggregate so the tiers sum to the overall record.
@@ -206,6 +213,7 @@ export function buildTaruchiDetails(input: BuildTaruchiDetailsInput): Map<string
     for (const idx of players) {
       if (seen.has(idx)) continue;
       seen.add(idx);
+      if (!shouldAccumulateIndex(idx)) continue;
       const pos = posByIdx.get(idx);
       if (pos === undefined) continue;
       const placement = positionToPlacement(pos, placements.length);
@@ -227,6 +235,7 @@ export function buildTaruchiDetails(input: BuildTaruchiDetailsInput): Map<string
     const p0 = placements[0];
     const p1 = placements[1];
     for (const idx of [d.playerAIndex, d.playerBIndex]) {
+      if (!shouldAccumulateIndex(idx)) continue;
       const pos = p0 === idx ? 0 : p1 === idx ? 1 : -1;
       if (pos === -1) continue;
       const placement = positionToPlacement(pos, placements.length);

packages/store-indexer/src/postgres/aggregateCache.ts

@@ -408,7 +408,7 @@ export function createLeaderboardCache(
     getStats: (wallet) => state.aggregate.byWallet.get(wallet.toLowerCase()) ?? null,
     getRoster: (wallet) => state.rosterByOwner.get(wallet.toLowerCase()) ?? [],
     getBattles: (wallet) => state.matchesByOwner.get(wallet.toLowerCase()) ?? [],
-    getTaruchi: (id) => state.detailById.get(String(id)) ?? null,
+    getTaruchi: (id) => state.detailById.get(id) ?? null,
     computedAt: () => state.computedAt,
     indexedBlock: () => state.indexedBlock,
     rebuildNow,