replace calldata with memory in libs

Author: frolic

packages/common/src/codegen/render-solidity/common.ts

@@ -2,6 +2,7 @@ import { ImportDatum, StaticResourceData, RenderKeyTuple, RenderType } from "./t
 import { resourceToHex } from "../../resourceToHex";
 import { hexToResource } from "../../hexToResource";
 import { renderImportPath } from "./renderImportPath";
+import { isDefined } from "../../utils";
 
 /**
  * Common header for all codegenerated solidity files
@@ -22,8 +23,11 @@ export function renderList<T>(list: T[], renderItem: (item: T, index: number) =>
  * Renders a comma-separated list of arguments for solidity functions, ignoring empty and undefined ones
  */
 export function renderArguments(args: (string | undefined)[]): string {
-  const filteredArgs = args.filter((arg) => arg !== undefined && arg !== "") as string[];
-  return internalRenderList(",", filteredArgs, (arg) => arg);
+  return args
+    .filter(isDefined)
+    .filter((arg) => arg !== "")
+    .map((arg) => arg.replace(/ calldata /, " memory "))
+    .join(", ");
 }
 
 interface RenderedCommonData {

packages/store/src/IStoreRegistration.sol

@@ -17,8 +17,8 @@ interface IStoreRegistration {
     FieldLayout fieldLayout,
     Schema keySchema,
     Schema valueSchema,
-    string[] memory keyNames,
-    string[] memory fieldNames
+    string[] calldata keyNames,
+    string[] calldata fieldNames
   ) external;
 
   // Register hook to be called when a record or field is set or deleted

packages/store/test/StoreMock.sol

@@ -127,8 +127,8 @@ contract StoreMock is Store {
     FieldLayout fieldLayout,
     Schema keySchema,
     Schema valueSchema,
-    string[] memory keyNames,
-    string[] memory fieldNames
+    string[] calldata keyNames,
+    string[] calldata fieldNames
   ) public virtual {
     StoreCore.registerTable(tableId, fieldLayout, keySchema, valueSchema, keyNames, fieldNames);
   }