Skip to content

Commit 1864466

Browse files
committed
change name of experiment function
1 parent 9257744 commit 1864466

File tree

2 files changed

+16
-9
lines changed

2 files changed

+16
-9
lines changed

Diff for: .github/workflows/demo_provisioning_scripts/DemoBuilder.py

+8-9
Original file line numberDiff line numberDiff line change
@@ -253,12 +253,11 @@ def create_contexts(self):
253253
# Create all the experiments
254254

255255
def create_and_run_experiments(self):
256-
self.run_ecommerce_funnel_experiment()
257-
self.run_ecommerce_feature_experiment()
256+
self.run_ecommerce_collection_banner_funnel_experiment()
257+
self.run_ecommerce_upsell_component_feature_experiment()
258258
self.run_togglebank_ai_config_experiment()
259259

260-
261-
def run_ecommerce_funnel_experiment(self):
260+
def run_ecommerce_collection_banner_funnel_experiment(self):
262261
if not self.metric_groups_created:
263262
print("Error: Metric groups not created")
264263
return
@@ -270,12 +269,12 @@ def run_ecommerce_funnel_experiment(self):
270269
"Turn on flag for experiment",
271270
)
272271
print(" - 09 - Funnel Experiment: Promotion Banner ")
273-
self.create_ecommerce_funnel_experiment()
272+
self.create_ecommerce_collection_banner_funnel_experiment()
274273
self.ldproject.start_exp_iteration("grow-engagement-with-promotion-banner", "production")
275274
print("Done")
276275
self.experiment_created = True
277276

278-
def create_ecommerce_funnel_experiment(self):
277+
def create_ecommerce_collection_banner_funnel_experiment(self):
279278
metrics = [
280279
self.ldproject.exp_metric("store-purchases", True),
281280
self.ldproject.exp_metric("in-cart-total-price", False)
@@ -290,7 +289,7 @@ def create_ecommerce_funnel_experiment(self):
290289
primary_key="store-purchases",
291290
)
292291

293-
def run_ecommerce_feature_experiment(self):
292+
def run_ecommerce_upsell_component_feature_experiment(self):
294293
if not self.metrics_created:
295294
print("Error: Metric not created")
296295
return
@@ -302,12 +301,12 @@ def run_ecommerce_feature_experiment(self):
302301
"Turn on flag for experiment",
303302
)
304303
print(" - 10 - Feature Experiment: Suggested Items Carousel")
305-
self.create_ecommerce_feature_experiment()
304+
self.create_ecommerce_upsell_component_feature_experiment()
306305
self.ldproject.start_exp_iteration("upsell-tracking-experiment", "production")
307306
print("Done")
308307
self.experiment_created = True
309308

310-
def create_ecommerce_feature_experiment(self):
309+
def create_ecommerce_upsell_component_feature_experiment(self):
311310
metrics = [
312311
self.ldproject.exp_metric("upsell-tracking", False),
313312
self.ldproject.exp_metric("in-cart-total-price", False)

Diff for: .github/workflows/demo_provisioning_scripts/LDPlatform.py

+8
Original file line numberDiff line numberDiff line change
@@ -636,6 +636,14 @@ def create_experiment(
636636
print("Error creating experiment: " + data["message"])
637637
return response
638638

639+
##################################################
640+
# Create a holdout
641+
##################################################
642+
643+
##################################################
644+
# Create a layer
645+
##################################################
646+
639647
##################################################
640648
# Create a release pipeline
641649
##################################################

0 commit comments

Comments
 (0)