Version 2.8.3 (#75)

## [2.8.3] - 2019-05-22
### Added
- Improved error handling on flag store migration.
### Fixed
- ClassCastException when migrating flag store from certain early Android SDK versions.

Author: gwhelanLD

CHANGELOG.md

@@ -3,6 +3,12 @@
 
 All notable changes to the LaunchDarkly Android SDK will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org).
 
+## [2.8.3] - 2019-05-22
+### Added
+- Improved error handling on flag store migration.
+### Fixed
+- ClassCastException when migrating flag store from certain early Android SDK versions.
+
 ## [2.8.2] - 2019-05-14
 ### Fixed
 - Thread leak (introduced in 2.8.0) when calling `identify()` on `LDClient` instances.

example/build.gradle

@@ -46,7 +46,7 @@ dependencies {
     implementation 'com.android.support:appcompat-v7:26.1.0'
     implementation project(path: ':launchdarkly-android-client-sdk')
     // Comment the previous line and uncomment this one to depend on the published artifact:
-    //implementation 'com.launchdarkly:launchdarkly-android-client-sdk:2.8.2'
+    //implementation 'com.launchdarkly:launchdarkly-android-client-sdk:2.8.3'
 
     implementation 'com.jakewharton.timber:timber:4.7.1'
 

launchdarkly-android-client-sdk/build.gradle

@@ -7,7 +7,7 @@ apply plugin: 'io.codearte.nexus-staging'
 
 allprojects {
     group = 'com.launchdarkly'
-    version = '2.8.2'
+    version = '2.8.3'
     sourceCompatibility = 1.7
     targetCompatibility = 1.7
 }

launchdarkly-android-client-sdk/src/main/java/com/launchdarkly/android/Migration.java

@@ -29,11 +29,19 @@ static void migrateWhenNeeded(Application application, LDConfig config) {
         }
 
         if (!migrations.contains("v2.6.0")) {
-            migrate_2_7_fresh(application, config);
+            try {
+                migrate_2_7_fresh(application, config);
+            } catch (Exception ex) {
+                Timber.w(ex, "Exception while performing fresh v2.7.0 store migration");
+            }
         }
 
         if (migrations.contains("v2.6.0") && !migrations.contains("v2.7.0")) {
-            migrate_2_7_from_2_6(application);
+            try {
+                migrate_2_7_from_2_6(application);
+            } catch (Exception ex) {
+                Timber.w(ex, "Exception while performing v2.6.0 to v2.7.0 store migration");
+            }
         }
     }
 
@@ -75,8 +83,11 @@ private static void migrate_2_7_fresh(Application application, LDConfig config)
                 String prefsKey = LDConfig.SHARED_PREFS_BASE_KEY + mobileKey + key + "-flags";
                 SharedPreferences.Editor userFlagStoreEditor = application.getSharedPreferences(prefsKey, Context.MODE_PRIVATE).edit();
                 for (String flagKey : flagKeys) {
-                    String flagString = reconstructFlag(flagKey, (String) flagData.get(flagKey), flagValues.get(flagKey));
-                    userFlagStoreEditor.putString(flagKey, flagString);
+                    Object flagVersionData = flagData.get(flagKey);
+                    if (flagVersionData instanceof String) {
+                        String flagString = reconstructFlag(flagKey, (String) flagVersionData, flagValues.get(flagKey));
+                        userFlagStoreEditor.putString(flagKey, flagString);
+                    }
                 }
                 stores = stores && userFlagStoreEditor.commit();
             }
@@ -114,8 +125,11 @@ private static void migrate_2_7_from_2_6(Application application) {
                 Map<String, ?> flagValues = application.getSharedPreferences(LDConfig.SHARED_PREFS_BASE_KEY + mobileKey + key + "-user", Context.MODE_PRIVATE).getAll();
                 SharedPreferences.Editor userFlagStoreEditor = application.getSharedPreferences(LDConfig.SHARED_PREFS_BASE_KEY + mobileKey + key + "-flags", Context.MODE_PRIVATE).edit();
                 for (String flagKey : flagKeys) {
-                    String flagString = reconstructFlag(flagKey, (String) flagData.get(flagKey), flagValues.get(flagKey));
-                    userFlagStoreEditor.putString(flagKey, flagString);
+                    Object flagVersionData = flagData.get(flagKey);
+                    if (flagVersionData instanceof String) {
+                        String flagString = reconstructFlag(flagKey, (String) flagVersionData, flagValues.get(flagKey));
+                        userFlagStoreEditor.putString(flagKey, flagString);
+                    }
                 }
                 allSuccess = allSuccess && userFlagStoreEditor.commit();
             }