Version 2.1.1 (#30)

* AndroidManifest.xml no longer enforces supportsRtl="true"
* Client no longer reconnects after detecting an invalidated mobile key
* Client can be initialized outside the main thread

Author: arun251

CHANGELOG.md

@@ -3,6 +3,12 @@
 
 All notable changes to the LaunchDarkly Android SDK will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org).
 
+## [2.1.1] - 2017-11-27
+### Fixed
+- `AndroidManifest.xml` no longer enforces `supportsRtl="true"`
+- Client no longer reconnects after detecting an invalidated mobile key
+- Client can be initialized outside the main thread. Thanks @jonathanmgrimm!
+
 ## [2.1.0] - 2017-10-13
 ### Added
 - `LDConfig.Builder#setUseReport` method to allow switching the request verb from `GET` to `REPORT`. Do not use unless advised by LaunchDarkly.

circle.yml

@@ -1,6 +1,7 @@
 # Disable emulator audio
 machine:
   environment:
+    GRADLE_OPTS: '-Dorg.gradle.jvmargs="-Xmx2048m -XX:+HeapDumpOnOutOfMemoryError"'
     QEMU_AUDIO_DRV: none
     version: oraclejdk8
 
@@ -32,4 +33,4 @@ test:
     - ./gradlew :launchdarkly-android-client:test --console=plain -PdisablePreDex
     - ./gradlew :launchdarkly-android-client:connectedAndroidTest --console=plain -PdisablePreDex
     - cp -r launchdarkly-android-client/build/reports/* $CIRCLE_TEST_REPORTS
-    - ./gradlew packageRelease --console=plain -PdisablePreDex
+    - ./gradlew packageRelease --console=plain -PdisablePreDex

example/src/main/AndroidManifest.xml

@@ -3,7 +3,7 @@
     package="com.launchdarkly.example">
 
     <application android:allowBackup="true" android:icon="@mipmap/ic_launcher"
-        android:label="@string/app_name" android:supportsRtl="true" android:theme="@style/AppTheme">
+        android:label="@string/app_name" android:theme="@style/AppTheme">
         <activity android:name=".MainActivity">
             <intent-filter>
                 <action android:name="android.intent.action.MAIN" />

example/src/main/java/com/launchdarkly/example/MainActivity.java

@@ -59,11 +59,13 @@ protected void onCreate(Bundle savedInstanceState) {
     @Override
     public void onStop() {
         super.onStop();
-        try {
-            ldClient.close();
-        } catch (IOException e) {
-            Log.e(TAG, "Exception when closing LaunchDarkly Client", e);
-        }
+        doSafeClientAction(() -> {
+            try {
+                ldClient.close();
+            } catch (IOException e) {
+                Log.e(TAG, "Exception when closing LaunchDarkly Client", e);
+            }
+        });
     }
 
     private void setupFlushButton() {

launchdarkly-android-client/build.gradle

@@ -8,7 +8,7 @@ apply plugin: 'io.codearte.nexus-staging'
 
 allprojects {
     group = 'com.launchdarkly'
-    version = '2.1.0'
+    version = '2.1.1'
     sourceCompatibility = 1.8
     targetCompatibility = 1.8
 }

launchdarkly-android-client/src/main/AndroidManifest.xml

@@ -11,8 +11,7 @@
     <uses-permission android:name="com.android.alarm.permission.SET_ALARM" />
 
     <application
-        android:label="@string/app_name"
-        android:supportsRtl="true">
+        android:label="@string/app_name">
         <receiver android:name=".PollingUpdater" />
         <receiver
             android:name=".ConnectivityReceiver"
@@ -23,4 +22,4 @@
         </receiver>
 
     </application>
-</manifest>
+</manifest>

launchdarkly-android-client/src/main/java/com/launchdarkly/android/LDClientInterface.java

@@ -1,8 +1,6 @@
 package com.launchdarkly.android;
 
 
-import android.content.Context;
-
 import com.google.gson.JsonElement;
 
 import java.io.Closeable;

launchdarkly-android-client/src/main/java/com/launchdarkly/android/PollingUpdater.java

@@ -51,7 +51,7 @@ synchronized static void startBackgroundPolling(Context context) {
 
     synchronized static void startPolling(Context context, int initialDelayMillis, int intervalMillis) {
         stop(context);
-        Log.d(TAG, "startPolling with initialDelayMillis: " + initialDelayMillis + " intervalMillis: " + intervalMillis);
+        Log.d(TAG,  String.format("startPolling with initialDelayMillis: %d and intervalMillis: %d", initialDelayMillis, intervalMillis));
         PendingIntent pendingIntent = getPendingIntent(context);
         AlarmManager alarmMgr = getAlarmManager(context);
 

launchdarkly-android-client/src/main/java/com/launchdarkly/android/StreamUpdateProcessor.java

@@ -28,6 +28,7 @@ class StreamUpdateProcessor implements UpdateProcessor {
     private final URI uri;
     private SettableFuture<Void> initFuture;
     private Debounce queue;
+    private boolean connection401Error = false;
 
     StreamUpdateProcessor(LDConfig config, UserManager userManager) {
         this.config = config;
@@ -40,7 +41,7 @@ public synchronized ListenableFuture<Void> start() {
         initFuture = SettableFuture.create();
         initialized.set(false);
 
-        if (!running) {
+        if (!running && !connection401Error) {
             stop();
             Log.d(TAG, "Starting.");
             Headers headers = new Headers.Builder()
@@ -97,6 +98,15 @@ public void onError(Throwable t) {
                             if (!initialized.getAndSet(true)) {
                                 initFuture.setException(t);
                             }
+                            if (code == 401) {
+                                connection401Error = true;
+                                try {
+                                    LDClient clientSingleton = LDClient.get();
+                                    clientSingleton.setOffline();
+                                } catch (LaunchDarklyException e) {
+                                    Log.e(TAG, "Client unavailable to be set offline", e);
+                                }
+                            }
                             stop();
                         }
                     }