Release 2.9.1 (#92)

## [2.9.1] - 2020-01-03
### Fixed:
- Removed possibility of fatal `SecurityException` on Samsung devices that would be triggered when the SDK attempted to register an alarm to trigger a future poll when the application process already had 500 alarms registered. This limit is only present on Samsung's versions of Android Lollipop and later. The SDK will now catch this error if it\
 occurs to prevent killing the host application.
- Rarely, the client would deliver its initial "identify" event to LaunchDarkly immediately rather than waiting for the configured flush interval.

Author: gwhelanLD

.circleci/config.yml

@@ -47,7 +47,9 @@ jobs:
           timeout: 1200
           no_output_timeout: 2h
 
-      - run: ./gradlew :launchdarkly-android-client-sdk:assembleDebug --console=plain -PdisablePreDex
+      - run:
+          name: Compile
+          command: ./gradlew :launchdarkly-android-client-sdk:assembleDebug --console=plain -PdisablePreDex
 
       - run:
           name: Wait for emulator to boot
@@ -73,12 +75,18 @@ jobs:
             adb logcat >> ~/artifacts/logcat.txt
 
       - run:
-          name: Run Tests
+          name: Run tests
           command: ./gradlew :launchdarkly-android-client-sdk:connectedAndroidTest --console=plain -PdisablePreDex
           no_output_timeout: 2h
 
-      - run: ./gradlew packageRelease --console=plain -PdisablePreDex
+      - run:
+          name: Validate package creation
+          command: ./gradlew packageRelease --console=plain -PdisablePreDex
 
+      - run:
+          name: Validate Javadoc
+          command: ./gradlew Javadoc
+      
       - run:
           name: Save test results
           command: |

CHANGELOG.md

@@ -3,6 +3,12 @@
 
 All notable changes to the LaunchDarkly Android SDK will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org).
 
+## [2.9.1] - 2020-01-03
+### Fixed:
+- Removed possibility of fatal `SecurityException` on Samsung devices that would be triggered when the SDK attempted to register an alarm to trigger a future poll when the application process already had 500 alarms registered. This limit is only present on Samsung's versions of Android Lollipop and later. The SDK will now catch this error if it occurs to prevent killing the host application.
+- Rarely, the client would deliver its initial "identify" event to LaunchDarkly immediately rather than waiting for the configured flush interval.
+- Fixed some malformed Javadoc comments.
+
 ## [2.9.0] - 2019-10-25
 ### Added
 - Added support for new LaunchDarkly experimentation features. See `LDClient.track(String, JsonElement, Double)` for recording numeric metrics.

example/build.gradle

@@ -46,7 +46,7 @@ dependencies {
     implementation 'com.android.support:appcompat-v7:26.1.0'
     implementation project(path: ':launchdarkly-android-client-sdk')
     // Comment the previous line and uncomment this one to depend on the published artifact:
-    //implementation 'com.launchdarkly:launchdarkly-android-client-sdk:2.9.0'
+    //implementation 'com.launchdarkly:launchdarkly-android-client-sdk:2.9.1'
 
     implementation 'com.jakewharton.timber:timber:4.7.1'
 

launchdarkly-android-client-sdk/build.gradle

@@ -7,7 +7,7 @@ apply plugin: 'io.codearte.nexus-staging'
 
 allprojects {
     group = 'com.launchdarkly'
-    version = '2.9.0'
+    version = '2.9.1'
     sourceCompatibility = 1.7
     targetCompatibility = 1.7
 }
@@ -40,10 +40,6 @@ android {
         execution 'ANDROID_TEST_ORCHESTRATOR'
     }
 
-    configurations {
-        javadocDeps
-    }
-
     compileOptions {
         sourceCompatibility JavaVersion.VERSION_1_7
         targetCompatibility JavaVersion.VERSION_1_7
@@ -89,10 +85,6 @@ dependencies {
     androidTestImplementation 'org.easymock:easymock:3.6'
     androidTestImplementation 'junit:junit:4.12'
     androidTestImplementation "com.squareup.okhttp3:mockwebserver:$okhttpVersion"
-
-    javadocDeps "com.google.code.gson:gson:$gsonVersion"
-    javadocDeps "com.squareup.okhttp3:okhttp:$okhttpVersion"
-    javadocDeps "com.launchdarkly:okhttp-eventsource:$eventsourceVersion"
 }
 
 repositories {
@@ -125,10 +117,15 @@ task sourcesJar(type: Jar) {
 }
 
 task javadoc(type: Javadoc) {
-    failOnError false
     source = android.sourceSets.main.java.srcDirs
     classpath += project.files(android.getBootClasspath().join(File.pathSeparator))
-    classpath += configurations.javadocDeps
+}
+
+afterEvaluate {
+// https://stackoverflow.com/questions/34571371/android-studio-javadoc-cannot-find-symbol/34572606#34572606
+    javadoc.classpath += files(android.libraryVariants.collect { variant ->
+        variant.javaCompile.classpath.files
+    })
 }
 
 task javadocJar(type: Jar, dependsOn: javadoc) {