Skip to content

Commit 4a91b1e

Browse files
chore: Make messageEvent.data cast safer and fix Android build
1 parent 129a6c4 commit 4a91b1e

File tree

4 files changed

+9
-6
lines changed

4 files changed

+9
-6
lines changed

packages/event_source_client/lib/src/sse_client_html.dart

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,11 @@ class HtmlSseClient implements SSEClient {
7272
void _handleMessageEvent(web.Event event) {
7373
_activeSince = DateTime.now().millisecondsSinceEpoch;
7474
final messageEvent = event as web.MessageEvent;
75-
final ldMessageEvent = ld_message_event.MessageEvent(
76-
messageEvent.type, (messageEvent.data as JSString).toDart, messageEvent.lastEventId);
77-
_messageEventsController.sink.add(ldMessageEvent);
75+
if (messageEvent.data != null && messageEvent.data.typeofEquals('string')) {
76+
final ldMessageEvent = ld_message_event.MessageEvent(messageEvent.type,
77+
(messageEvent.data as JSString).toDart, messageEvent.lastEventId);
78+
_messageEventsController.sink.add(ldMessageEvent);
79+
}
7880
}
7981

8082
/// Subscribe to this [stream] to receive events and sometimes errors. The first

packages/flutter_client_sdk/example/android/app/src/main/AndroidManifest.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
2+
<uses-permission android:name="android.permission.INTERNET" />
23
<application
34
android:label="example"
45
android:name="${applicationName}"

packages/flutter_client_sdk/example/android/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
33
zipStoreBase=GRADLE_USER_HOME
44
zipStorePath=wrapper/dists
5-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.3-all.zip
5+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-all.zip

packages/flutter_client_sdk/example/android/settings.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ pluginManagement {
1818

1919
plugins {
2020
id "dev.flutter.flutter-plugin-loader" version "1.0.0"
21-
id "com.android.application" version "7.3.0" apply false
22-
id "org.jetbrains.kotlin.android" version "1.7.10" apply false
21+
id "com.android.application" version "8.3.0" apply false
22+
id "org.jetbrains.kotlin.android" version "1.8.10" apply false
2323
}
2424

2525
include ":app"

0 commit comments

Comments
 (0)