review comments

Author: tanderson-ld

packages/common_client/lib/src/context_modifiers/anonymous_context_modifier.dart

@@ -20,7 +20,7 @@ final class AnonymousContextModifier implements ContextModifier {
   @override
   Future<LDContext> decorate(LDContext context) async {
     if (!context.valid) {
-      _logger.info(
+      _logger.warn(
           'AnonymousContextModifier was asked to modify an invalid context and will attempt to do so. This is expected if starting with an empty context.');
     }
     // Before we make a builder we should check if any anonymous contexts

packages/common_client/lib/src/context_modifiers/env_context_modifier.dart

@@ -43,7 +43,7 @@ final class AutoEnvContextModifier implements ContextModifier {
   @override
   Future<LDContext> decorate(LDContext context) async {
     if (!context.valid) {
-      _logger.info(
+      _logger.warn(
           'AutoEnvContextModifier was asked to modify an invalid context and will attempt to do so. This is expected if starting with an empty context.');
     }
 

packages/common_client/lib/src/ld_common_client.dart

@@ -131,8 +131,7 @@ final class LDCommonClient {
 
   late final DataSourceManager _dataSourceManager;
   late final EnvironmentReport _envReport;
-  late final AsyncSingleQueue<IdentifyResult> _identifyQueue =
-      AsyncSingleQueue();
+  late final AsyncSingleQueue<void> _identifyQueue = AsyncSingleQueue();
   late final DataSourceFactoriesFn _dataSourceFactories;
 
   // Modifications will happen in the order they are specified in this list.
@@ -275,7 +274,7 @@ final class LDCommonClient {
     // having been set resulting in a crash.
     _identifyQueue.execute(() async {
       await _startInternal();
-      return _identifyInternal(_initialUndecoratedContext,
+      await _identifyInternal(_initialUndecoratedContext,
           waitForNetworkResults: waitForNetworkResults);
     }).then((res) {
       _startCompleter!.complete(_mapIdentifyResult(res));
@@ -422,52 +421,46 @@ final class LDCommonClient {
       return IdentifyError(Exception(message));
     }
     final res = await _identifyQueue.execute(() async {
-      return _identifyInternal(context,
+      await _identifyInternal(context,
           waitForNetworkResults: waitForNetworkResults);
     });
     return _mapIdentifyResult(res);
   }
 
-  Future<IdentifyResult> _mapIdentifyResult(
-      TaskResult<IdentifyResult> res) async {
+  Future<IdentifyResult> _mapIdentifyResult(TaskResult<void> res) async {
     switch (res) {
-      case TaskComplete<IdentifyResult>(result: var result):
-        return result ?? IdentifyComplete();
-      case TaskShed<IdentifyResult>():
+      case TaskComplete<void>():
+        return IdentifyComplete();
+      case TaskShed<void>():
         return IdentifySuperseded();
-      case TaskError<IdentifyResult>(error: var error):
+      case TaskError<void>(error: var error):
         return IdentifyError(error);
     }
   }
 
-  Future<IdentifyResult> _identifyInternal(LDContext context,
+  Future<void> _identifyInternal(LDContext context,
       {bool waitForNetworkResults = false}) async {
     if (!context.valid) {
       const message =
           'LDClient was provided an invalid context. The context will be ignored. Existing flags will be used for evaluations until identify is called with a valid context.';
       _logger.warn(message);
-      return IdentifyError(Exception(message));
+      throw Exception(message);
     }
 
-    try {
-      await _setAndDecorateContext(context);
-      final completer = Completer<void>();
-      _eventProcessor?.processIdentifyEvent(IdentifyEvent(context: _context));
-      final loadedFromCache = await _flagManager.loadCached(_context);
+    await _setAndDecorateContext(context);
+    final completer = Completer<void>();
+    _eventProcessor?.processIdentifyEvent(IdentifyEvent(context: _context));
+    final loadedFromCache = await _flagManager.loadCached(_context);
 
-      if (_config.offline) {
-        return IdentifyComplete();
-      }
-      _dataSourceManager.identify(_context, completer);
+    if (_config.offline) {
+      return;
+    }
+    _dataSourceManager.identify(_context, completer);
 
-      if (loadedFromCache && !waitForNetworkResults) {
-        return IdentifyComplete();
-      }
-      await completer.future;
-      return IdentifyComplete();
-    } catch (error) {
-      return IdentifyError(error);
+    if (loadedFromCache && !waitForNetworkResults) {
+      return;
     }
+    return completer.future;
   }
 
   /// Returns the value of flag [flagKey] for the current context as a bool.

packages/common_client/test/context_decorators/anonymous_context_modifier_test.dart

@@ -136,7 +136,7 @@ void main() {
 
       final logRecord = verify(() => mockAdapter.log(captureAny())).captured[0]
           as LDLogRecord;
-      expect(logRecord.level, LDLogLevel.info);
+      expect(logRecord.level, LDLogLevel.warn);
       expect(logRecord.message,
           'AnonymousContextModifier was asked to modify an invalid context and will attempt to do so. This is expected if starting with an empty context.');
     });

packages/common_client/test/context_decorators/env_context_modifier_test.dart

@@ -487,7 +487,7 @@ void main() {
 
       final logRecord = verify(() => mockAdapter.log(captureAny())).captured[0]
           as LDLogRecord;
-      expect(logRecord.level, LDLogLevel.info);
+      expect(logRecord.level, LDLogLevel.warn);
       expect(logRecord.message,
           'AutoEnvContextModifier was asked to modify an invalid context and will attempt to do so. This is expected if starting with an empty context.');
     });

packages/event_source_client/lib/src/sse_client_html.dart

@@ -121,5 +121,3 @@ SSEClient getSSEClient(
         EventSourceLogger? logger) =>
     // dropping unsupported configuration options
     HtmlSseClient(uri, eventTypes, logger);
-
-// TODO: see if logging can be piped through to html source