Skip to content

Commit 94b9c2e

Browse files
authored
chore: fixing usage of generated mock to not require change to mock (#413)
1 parent 9fc3e15 commit 94b9c2e

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

LaunchDarkly/GeneratedCode/mocks.generated.swift

+2-2
Original file line numberDiff line numberDiff line change
@@ -214,12 +214,12 @@ final class EventReportingMock: EventReporting {
214214
}
215215

216216
var recordFlagEvaluationEventsCallCount = 0
217-
var recordFlagEvaluationEventsCallback: ((_ event: FeatureEvent) throws -> Void)?
217+
var recordFlagEvaluationEventsCallback: (() throws -> Void)?
218218
var recordFlagEvaluationEventsReceivedArguments: (flagKey: LDFlagKey, value: LDValue, defaultValue: LDValue, featureFlag: FeatureFlag?, context: LDContext, includeReason: Bool)?
219219
func recordFlagEvaluationEvents(flagKey: LDFlagKey, value: LDValue, defaultValue: LDValue, featureFlag: FeatureFlag?, context: LDContext, includeReason: Bool) {
220220
recordFlagEvaluationEventsCallCount += 1
221221
recordFlagEvaluationEventsReceivedArguments = (flagKey: flagKey, value: value, defaultValue: defaultValue, featureFlag: featureFlag, context: context, includeReason: includeReason)
222-
try! recordFlagEvaluationEventsCallback?(FeatureEvent(key: flagKey, context: context, value: value, defaultValue: defaultValue, featureFlag: featureFlag, includeReason: includeReason, isDebug: false))
222+
try! recordFlagEvaluationEventsCallback?()
223223
}
224224

225225
var flushCallCount = 0

LaunchDarkly/LaunchDarklyTests/LDClientSpec.swift

+6-2
Original file line numberDiff line numberDiff line change
@@ -721,10 +721,14 @@ final class LDClientSpec: QuickSpec {
721721
let flagAC = FeatureFlag(flagKey: "flagAC", value: LDValue.bool(true), trackEvents: false, trackReason: false, prerequisites: ["flagA"])
722722
let flagABD = FeatureFlag(flagKey: "flagABD", value: LDValue.bool(true), trackEvents: false, trackReason: false, prerequisites: ["flagAB"])
723723
let flags: [LDFlagKey: FeatureFlag] = ["flagA": flagA, "flagAB": flagAB, "flagAC": flagAC, "flagABD": flagABD]
724-
var storedItems = StoredItems(items: flags)
724+
let storedItems = StoredItems(items: flags)
725725
testContext.flagStoreMock.replaceStore(newStoredItems: storedItems)
726726
var events = [FeatureEvent]()
727-
testContext.eventReporterMock.recordFlagEvaluationEventsCallback = { events.append($0) }
727+
testContext.eventReporterMock.recordFlagEvaluationEventsCallback = {
728+
let args = testContext.eventReporterMock.recordFlagEvaluationEventsReceivedArguments!
729+
let event = FeatureEvent(key: args.flagKey, context: args.context, value: args.value, defaultValue: args.defaultValue, featureFlag: args.featureFlag, includeReason: args.includeReason, isDebug: false)
730+
events.append(event)
731+
}
728732
_ = testContext.subject.boolVariation(forKey: "flagA", defaultValue: DefaultFlagValues.bool)
729733
_ = testContext.subject.boolVariation(forKey: "flagAB", defaultValue: DefaultFlagValues.bool)
730734
_ = testContext.subject.boolVariation(forKey: "flagAC", defaultValue: DefaultFlagValues.bool)

0 commit comments

Comments
 (0)